Support for PATCH about fhir-works-on-aws-routing

[rsmayda]

Hey @lyndoh after further review, I have no modifications or qualms with this approach. This makes a great deal of sense and we would support this sort of PR. As you mentioned this would be a backwards breaking change so I believe the order of operations would be:

1. Update interface (bumping major version) - removing the interface method
   • Please add comments explaining that due to the FHIR spec is makes more sense for this to be a contained within the router
2. Update persistence (bumping major version) - removing the method
3. Update routing (bumping minor version - since the patch route would still be support but just in a different way)
4. Update deployment package - (do we need to do anything to support a new header? application/json-patch+json)

For steps on setting up your local environment please check out our: https://github.com/awslabs/fhir-works-on-aws-deployment/blob/mainline/DEVELOPMENT.md

Since all of these PRs will be linked so heavily we will not merge the interface PR (and subsequently bump the npm version) until we are able to see the other changes code.

We look forward to this awesome contribution!

[rsmayda]

Thank you so much for a thoughtful response. Let us review this in depth, since like you mention it will be a backward breaking change. At face value this looks like a good logical approach but we will get back to you soon.

Just for our planning do you guys have a deadline?

[lyndoh]

Thanks, deadline is not too soon.

[lyndoh]

Thanks that all sounds good. We'll look to get started on this soon.

[kcadette]

FHIR Works on AWS has been moved to maintenance mode. While in maintenance, we will not add any new features to this solution. All security issues should be reported directly to AWS Security at [email protected]. If you are new to this solution, we advise you to explore using HealthLake, which is our managed service for building FHIR based transactional and analytics applications. You can get started by contacting your AWS Account team. If you are an existing customer
of FHIR Works on AWS, and have additional questions or need immediate help, please reach out to [email protected] or contact your AWS Account team.