Coder Social home page Coder Social logo

Comments (7)

jpignata avatar jpignata commented on May 10, 2024

One design choice I made here in the spirit of "reasonable defaults" was to use the default VPC rather than spinning up an entirely separate VPC or asking the user to provide a VPC ID to not litter a user's account and to prevent option sprawl respectively. My thought was that a user encountering this error could just re-create their default VPC (via http://docs.aws.amazon.com/AmazonVPC/latest/UserGuide/default-vpc.html#create-default-vpc).

It'd be nice to help the user out here though. It seems like this could be tackled a number of different ways. If the default VPC isn't available, we could do one or more of the following options:

  1. Return an error and ask the user to provide a VPC ID when creating new services and load balancers and running new tasks
  2. Create a new VPC and n subnets (where n = the number of availability zones the account can access)
  3. Create a new default VPC (which is a single API call)
  4. Continue to blow up, but return a more useful error message explaining how to create a default VPC

I'm learning toward returning a more useful error message as a user might have had good reason not to want a default VPC.

Any thoughts/opinions? Thanks so much for opening this.

from fargatecli.

lecole avatar lecole commented on May 10, 2024

I would think, it would be best to provide a VPC ID and Cluster Name on the command line. As we have several Clusters and VPCs that we use to separate out services.

from fargatecli.

jpignata avatar jpignata commented on May 10, 2024

@lecole Thanks. I think I'm sold on adding cluster as a command line option for task and service commands.

I'm still not sure on the above VPC question though. Asking the user to provide a VPC ID seems to introduce mental overhead and could potentially create issues. i.e., I create a load balancer in one VPC, and try to use it in another. Now there's another new magic string I need to correlate. I suppose we could default to the default VPC, and just allow it to be overridden (a la option 1 above).

from fargatecli.

lecole avatar lecole commented on May 10, 2024

@jpignata Sounds like a good plan. But what if you also added the VPC as an option and then also implemented option 1. This would give some control over which VPC you want it to go into (without the error), and also as a default have the "default VPC" as the target deployment location.

from fargatecli.

jpignata avatar jpignata commented on May 10, 2024

@lecole Thanks for the input! I'll tinker with this over the next day or two and try to get a 0.2.0 release together with something to address these two pain points.

from fargatecli.

lecole avatar lecole commented on May 10, 2024

Sounds good. Great work so far.

from fargatecli.

jpignata avatar jpignata commented on May 10, 2024

Released v0.2.0 to address the above.

from fargatecli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.