Remove package global state about aws-xray-sdk-go

[luluzhao]

Hi @cep21 , we plan to release this feature soon if there is no delay. Sorry for the inconvenience it might cause and please stay tuned.

[kaidence]

Hi! I'd like to echo cep21's concerns. We'd love to be on the main x-ray library, though. Is this something your team is actively working on? Do you accept PRs?

[luluzhao]

@kaidence , we are working on it right now and hopefully it will be released soon. We do accept PRs and feel free send it. Thank you.

[cep21]

Hi,

Looking forward to using x-ray. Any update on this task?

Thanks!

[luigi-riefolo]

@luluzhao what's the state of this feature?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[bhautikpip]

Hi @luigi-riefolo,

We have merged this PR about logging interface (#82). I think we still need to prioritize removing global mutable state and removing deep dependencies tree in Xray Go SDK design.

[luigi-riefolo]

@bhautikpip can we close this PR then?

[bhautikpip]

Hi @luigi-riefolo,

I think we can keep this open as a reference point if that's okay.

[bhautikpip]

Hi @cep21,

As we are prioritizing this efforts, would you mind providing your suggestions on addressing global mutable state concerns in XRay Go SDK ? Also, really appreciate any design ideas to remove deep dependency tree.

[luigi-riefolo]

@bhautikpip @cep21 the library has significantly changed since this issue was created.
We first need to list all files that still have global states

[cep21]

I can't give input since i don't use the library anymore. If you've made improvements, that's great news!

[bhautikpip]

Hi @luigi-riefolo,

Yes. That's a good starting point. We have tried to remove it wherever we can. That's why I have posted this question to seek feedback from library users to get some more pointers on where we see global states and removing from there would be a good idea.

[bhautikpip]

Hi,

Thank you all for opening this issue. Since GA release we have tried to cover this point and try to reduce global states in the library wherever it's possible. I am closing this issue since it's very old. Feel free to open new one if we can improve at any other place in the library. Thanks again!