Comments (14)
Hi @cep21 , we plan to release this feature soon if there is no delay. Sorry for the inconvenience it might cause and please stay tuned.
from aws-xray-sdk-go.
Hi! I'd like to echo cep21's concerns. We'd love to be on the main x-ray library, though. Is this something your team is actively working on? Do you accept PRs?
from aws-xray-sdk-go.
@kaidence , we are working on it right now and hopefully it will be released soon. We do accept PRs and feel free send it. Thank you.
from aws-xray-sdk-go.
Hi,
Looking forward to using x-ray. Any update on this task?
Thanks!
from aws-xray-sdk-go.
@luluzhao what's the state of this feature?
from aws-xray-sdk-go.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from aws-xray-sdk-go.
Hi @luigi-riefolo,
We have merged this PR about logging interface (#82). I think we still need to prioritize removing global mutable state and removing deep dependencies tree in Xray Go SDK design.
from aws-xray-sdk-go.
@bhautikpip can we close this PR then?
from aws-xray-sdk-go.
Hi @luigi-riefolo,
I think we can keep this open as a reference point if that's okay.
from aws-xray-sdk-go.
Hi @cep21,
As we are prioritizing this efforts, would you mind providing your suggestions on addressing global mutable state concerns in XRay Go SDK ? Also, really appreciate any design ideas to remove deep dependency tree.
from aws-xray-sdk-go.
@bhautikpip @cep21 the library has significantly changed since this issue was created.
We first need to list all files that still have global states
from aws-xray-sdk-go.
I can't give input since i don't use the library anymore. If you've made improvements, that's great news!
from aws-xray-sdk-go.
Hi @luigi-riefolo,
Yes. That's a good starting point. We have tried to remove it wherever we can. That's why I have posted this question to seek feedback from library users to get some more pointers on where we see global states and removing from there would be a good idea.
from aws-xray-sdk-go.
Hi,
Thank you all for opening this issue. Since GA release we have tried to cover this point and try to reduce global states in the library wherever it's possible. I am closing this issue since it's very old. Feel free to open new one if we can improve at any other place in the library. Thanks again!
from aws-xray-sdk-go.
Related Issues (20)
- Mutex deadlock HOT 1
- The v2 version xray doesn't work for dynamodb putItem api HOT 3
- Vulnerabilities in aws-sdk-go v1.18.0 HOT 3
- X-Ray for a lambda function HOT 1
- panic when using timestream QueryWithContext with X-Ray
- Fix vulnerability of google.golang.org/[email protected] module HOT 1
- Use Go SDK V2 HOT 2
- SDK V2 intrumentation of DynamoDB doesn't capture table name HOT 2
- omit URL's password when stringifying URL for segment name HOT 2
- Upgrade from `github.com/golang/protobuf` to `google.golang.org/protobuf` HOT 3
- xray.SqlContext duplicates all non-trivial SQL in trace HOT 2
- Remove the use of github.com/pkg/errors as its moved to Archived. HOT 1
- How do I add a custom detector to allow seamless snowflake integration? HOT 2
- Segment silently fails to flush when a subsegment is created with a closed parent HOT 1
- Fix vulnerability of golang.org/x/[email protected] CVE-2023-45288 CWE-770 HOT 2
- UDP message length too long for segments send to daemon HOT 1
- instance metadata related error when running ecs sidecar container for xray HOT 1
- using x-ray with aws-sdk-v2 makes the binary files bigger than expected HOT 1
- Tests Failing -- `TestBadRoundTripDial` HOT 1
- Migrate xray sampling from aws sdk for go v1 to v2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aws-xray-sdk-go.