Coder Social home page Coder Social logo

Comments (11)

trivikr avatar trivikr commented on June 12, 2024

If you have a minimal repro, please post it in the issue comments. I'll also post my attempts in reproducing.
It'll help identify in which version it was introduced. We suspect it was introduced in either v3.564.0 or v3.565.0

The current workaround is to pin your client dependency to <3.564.0 in package.json as follows:

   "client-dynamodb": "<3.564.0",

from aws-sdk-js-v3.

trivikr avatar trivikr commented on June 12, 2024

I'm not able to repro with this simple commands in a new workspace, and dependencies are installed

$ node -v
v20.12.2

$ corepack enable && yarn set version 4.2.1

$ yarn init -y && yarn add @aws-sdk/[email protected] --exact

from aws-sdk-js-v3.

trivikr avatar trivikr commented on June 12, 2024

Minimal repro with [email protected] shows warnings

$ corepack enable && yarn set version 3.5.0

$ yarn init -y && yarn add @aws-sdk/[email protected] --exact
...
➤ YN0000: ┌ Resolution step
➤ YN0002: │ @aws-sdk/credential-provider-node@npm:3.567.0 doesn't provide @aws-sdk/client-sts (pd83b4), requested by @aws-sdk/credential-provider-web-identity
➤ YN0002: │ @aws-sdk/credential-provider-node@npm:3.567.0 doesn't provide @aws-sdk/client-sts (p294b1), requested by @aws-sdk/credential-provider-ini
➤ YN0002: │ @aws-sdk/credential-provider-sso@npm:3.567.0 doesn't provide @aws-sdk/client-sso-oidc (pb330e), requested by @aws-sdk/token-providers
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 0s 805ms
...

Not reproducible with 3.563.0

from aws-sdk-js-v3.

trivikr avatar trivikr commented on June 12, 2024

The warning is shown in [email protected] as direct dependency of client-sts was removed in #6028. The dependency was removed because other clients were not using it directly. The dependency, however, is required in some default credential providers like credential-provider-web-identity or credential-provider-ini.

In those credential providers, the dependency is added as a peerDependency to avoid circular dependency issue. This is not a problem for majority users, since most of the requests sent on JS SDK do not use those credential providers. For other users, most of them use npm 7+ which automatically installs peerDependencies.

However, it would be a problem for certain package managers where peerDependencies are not automatically installed (like yarn modern) and there's no workaround to install those peerDependencies (like yarn classic).

We're exploring re-adding the direct dependencies on clients.

from aws-sdk-js-v3.

conico974 avatar conico974 commented on June 12, 2024

@trivikr It can also cause issue if you set auto-install-peers=false in .npmrc
Also in some cases in CI, it seems that npx also doesn't install peer dependencies which make CI fail.

from aws-sdk-js-v3.

trivikr avatar trivikr commented on June 12, 2024

We're exploring re-adding the direct dependencies on clients.

PR posted at #6055

from aws-sdk-js-v3.

trivikr avatar trivikr commented on June 12, 2024

PR posted at #6055

PR is merged, and the fix is expected to be published in https://github.com/aws/aws-sdk-js-v3/releases/tag/v3.569.0 around 12:30 PM Pacific on Friday, May 3.

Reopening this issue for verification post publish.

from aws-sdk-js-v3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.