Coder Social home page Coder Social logo

Comments (7)

2opremio avatar 2opremio commented on July 17, 2024

@samuelkarp Would you be open to a PR implementing this?

from amazon-ecs-cli.

samuelkarp avatar samuelkarp commented on July 17, 2024

@2opremio, sure!

from amazon-ecs-cli.

2opremio avatar 2opremio commented on July 17, 2024

@samuelkarp I see two options here:

  1. Allow changing the role to something other than AmazonEC2ContainerServiceforEC2Role
  2. Allow overriding the full instance policy

We could do both (1) and (2) but, if we assume we only want one option, I would go for (2) since (1) has the extra dependency of creating a managed policy in advance (if a preexisting managed policy is not good enough).

Thoughts?

from amazon-ecs-cli.

samuelkarp avatar samuelkarp commented on July 17, 2024

A role can have multiple policies, so it is probably more flexible to allow additional policies. See the CloudFormation documentation for information on associating multiple policies with a role.

from amazon-ecs-cli.

2opremio avatar 2opremio commented on July 17, 2024

@samuelkarp Sorry it took a while to answer. Even if we allow additional policies it would require the user to create those with a different tool (Console, AWS CLI etc ...) which can be inconvenient. In our usecase it would be more useful to allow defining the full role. Would this be OK?

I think I may find some time to do this in about a week (next week is going to be really busy for me)..

from amazon-ecs-cli.

 avatar commented on July 17, 2024

Is there any chance of this issue getting addressed?

from amazon-ecs-cli.

SoManyHs avatar SoManyHs commented on July 17, 2024

We are planning on allowing a new flag, --role, which will allow customers to pass in the ARN of a custom IAM Role. At this time, the customer will still need to create this role outside of the ECS CLI (e.g. via Console, AWS CLI etc). We will also still attach the AmazonEC2ContainerServiceforEC2Role policy to this role, i.e. the customer will not be able to specify a custom IAM Policy.

from amazon-ecs-cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.