Bug: Parameters custom provider's client is expected as a AWS SDK Client about powertools-lambda-typescript

[karthikeyanjp]

we can close this issue. Thanks @am29d for the quick check.

[am29d]

Hey @karthikeyanjp ,

this is indeed a bug that should not happen if you pass your custom client that is not AWS SDK. I will fix the issue quickly to unblock you.

[am29d]

Hey @karthikeyanjp ,

I had a hard time to reproduce the error in our tests and now I see the problem. The error you see and the stackTrace is a console.warn message in addUserAgentMiddleware, your code executes successfully. We throw an error if we can't add user agent but also catch it for a warning log. We don't want to block execution if there are any issues with the user agent, thus we just print it.

While we could potentially remove our throw Error, it's still helpful to have a log inside the catch to understand what went wrong.

With this in mind, you should be able to implement your custom provider for parameters. If there are any open questions let me know, otherwise I will close the issue.

[karthikeyanjp]

Thanks @am29d. You are right, it's only a warning. But figured the log statements could be misleading as addUserAgentMiddleware is only a AWS SDK functionality and our log analyzer picked this as an Error because of the description. Alternate is to retain the throw error and to call addUserAgentMiddleware only for AWS SDK clients.

[github-actions]

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.