Coder Social home page Coder Social logo

Comments (7)

stnor avatar stnor commented on June 29, 2024

What sampler are you using? Why 100% sampling? That will have a perf impact.

I used -Dotel.traces.sampler.traceidratio=true -Dotel.traces.sampler.arg=0.005 and had perf issues (cpu util rose w/ 50%).

Switched to the parent based ratio sampler parentbased_traceidratio and that had a huge impact for me, but I am using a lot of internal spans.

from aws-otel-java-instrumentation.

kurvatch avatar kurvatch commented on June 29, 2024

@stnor parentbased_always_on is the sampler. I am testing things out with default configurations, it was expected there will be a performance impact with 100% sampling but was shocked to see more than 50% degradation of throughput. I am doing another round of testing with parentbased_traceidratio and -Dotel.traces.sampler.arg=0.25 for the same application.

from aws-otel-java-instrumentation.

stnor avatar stnor commented on June 29, 2024

25% is a very high sampling frequency in my experience.

from aws-otel-java-instrumentation.

kurvatch avatar kurvatch commented on June 29, 2024

Is there a standards recommendation available. It would defiantly help to publish benchmark performance with different samplers and ratios with a demo application interacting database and a message system

from aws-otel-java-instrumentation.

anuraaga avatar anuraaga commented on June 29, 2024

Hi @kurvatch - I agree that the performance impact seems much larger than we'd expect. Sampling rate is great for reducing load on backends, but we wouldn't expect such that much overhead at hundreds of QPS.

I have filed open-telemetry/opentelemetry-java-instrumentation#3047 as that repo is where the actual code is and the performance bottlenecks can be investigated.

from aws-otel-java-instrumentation.

github-actions avatar github-actions commented on June 29, 2024

This issue is stale because it has been open 90 days with no activity. If you want to keep this issue open, please just leave a comment below and auto-close will be canceled

from aws-otel-java-instrumentation.

github-actions avatar github-actions commented on June 29, 2024

This issue was closed because it has been marked as stale for 30 days with no activity.

from aws-otel-java-instrumentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.