AWS.MediaLive.list_channels/1 returns a status_code: 403 response about aws-elixir

[vrcca]

Checking the API.json for this, their shape doesn't include a body type, but only querystring types. Maybe the generator could check this instead? 🤔

[philss]

I fixed the problem by setting an empty body for GET requests. According to the HTTP specs we shouldn't have a body in case of a GET or HEAD or OPTIONS requests, so I think this is safe. This fix was released in v0.9.1. Thank you all!

[philss]

Hi @pranavraja 👋

Perhaps we shouldn't encode when the input is nil. Or maybe GET requests shouldn't be encode. I'm not sure :/
I will take a look later this week, but if you don't mind to confirm that and open the PR, it would be awesome! :D

[pranavraja]

Yeah not sure which option would be cleaner, in any case I checked the repo and all uses of :get pass in nil as the input anyway, whereas other http verbs do pass in an input, so it seems either way would fix the issue. Do you have a preference?

[philss]

@pranavraja sorry for the delay. I think we can go with not encoding GET requests. WDYT?

[philipgiuliani]

We have the same issue for describe_input, describe_channel . In the meanwhile we resolved it with the following code:

defmodule OurApp.AWS.MediaLive do
  def describe_channel(client, id) do
    request(client, "/prod/channels/#{AWS.Util.encode_uri(id)}")
  end

  def describe_input(client, id) do
    request(client, "/prod/inputs/#{AWS.Util.encode_uri(id)}")
  end

  defp request(client, url) do
    AWS.Request.request_rest(
      client,
      AWS.MediaLive.metadata(),
      :get,
      url,
      [],
      [],
      %{"Body" => ""},
      [send_body_as_binary?: true],
      200
    )
  end
end