Coder Social home page Coder Social logo

Comments (3)

lawmicha avatar lawmicha commented on August 14, 2024

I think this is P1 due to JS not recursively calling LLC when more than 1000 items

from amplify-swift.

jamesonwilliams avatar jamesonwilliams commented on August 14, 2024

I think we should decide on a consistent list/query paradigm across all of our categories. One possibility is to always return an iterator/iterable, so that we can do pagination under the hood, on behalf of the user, if they seek next() beyond a page boundary:

Amplify.Storage.list(
    bucketUri,
    iterator -> {
        while (iterator.hasNext()) {
            Log.i(TAG, "Item: " + iterator.next().toString());
        }
    },
    error -> Log.e(TAG, "Failed to get items from storage.", error)
);

If we don't do that, then we should provide the user with a way to handle their own pagination, and perhaps just give them back a collection/list:

Amplify.Storage.list(
    bucketUri,
    nextToken, // Nota Bien!
    listResults -> {
        // Pseudo-code to show some of the necessary fields in the `listResults`:
        final int pageNumber = listResults.getPageNumber();
        final String nextToken = listResults.getNextToken();
        final Collection<StorageItem> listResults.getItems();
    },
    error -> Log.e(TAG, "Failed to get any results.", error)
);

from amplify-swift.

lawmicha avatar lawmicha commented on August 14, 2024

thanks for the comment, i've moved this over to pivotal and referenced this issue for the context. closing this out to track on pivotal

from amplify-swift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.