Coder Social home page Coder Social logo

Comments (5)

cshfang avatar cshfang commented on June 3, 2024 2

@brentvatne - thanks for bringing this up. I have a couple of a clarifying questions:

  1. Is the ask to validate that amazon-cognito-identity-js works as-is with RN 0.74? I.e. there is not an ask here to update the package itself and
  2. Is this at all related to Expo Go?

from amplify-js.

cshfang avatar cshfang commented on June 3, 2024 2

Gotcha. Will follow up with the team tomorrow morning and figure out a test plan.

Thanks!

from amplify-js.

cwomack avatar cwomack commented on June 3, 2024 2

@brentvatne, we're marking this as a feature request and are reviewing this internally as @cshfang stated above. We'll let you know if there's any further questions. Thanks!

from amplify-js.

brentvatne avatar brentvatne commented on June 3, 2024

hi @cshfang! thanks for the quick response.

  1. Is the ask to validate that amazon-cognito-identity-js works as-is with RN 0.74? I.e. there is not an ask here to update the package itself

correct! specifically, that it works with the latest [email protected] with the new architecture, with bridgeless enabled and without it enabled, using the information in this doc as guidance: https://gist.github.com/cipolleschi/82b7a9561b8861330efabbd3eb08c6f5

I expect that it will just work because 0.74-rc enables an interop layer by default for new arch, and this module is fairly simple, but it would be good to verify!

  1. Is this at all related to Expo Go?

nope!

from amplify-js.

cshfang avatar cshfang commented on June 3, 2024

@brentvatne

Sorry for not getting back to you sooner. Obviously, at this point, RN 0.74 has been out for weeks 🤦

We did actually run through most of the use cases for amazon-cognito-identity-js against RN 0.74 with and without bridgeless mode enabled on the new an old architecture and were able to confirm that everything worked as expected (as you suspected). We'll keep this ticket open for now to see if we need more in-depth testing but I appreciate you helping us to try to get ahead of this ❤️

from amplify-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.