Coder Social home page Coder Social logo

Comments (5)

mholt avatar mholt commented on May 8, 2024

Yep! Thank you. Just keep it alphabetized and that'll be good! (Feel free to submit a PR)

from awesome-go.

dmitshur avatar dmitshur commented on May 8, 2024

I think it's absolutely fine to rename your package if you think it's better. You are the owner.

Actually I was trying my best to follow the new golang blog, Package Names

That page says the following:

Good package names are short and clear. They are lower case, with no under_scores or mixedCaps.

The style of names typical of another language might not be idiomatic in a Go program. Here are two examples of names that might be good style in other languages but do not fit well in Go:

  • computeServiceClient
  • priority_queue

I just want to point out, your new package name seems to be equally discouraged in that section like the old. Is that intentional?

from awesome-go.

pravj avatar pravj commented on May 8, 2024

Ohh my god.

This will obviously indicate that I was not functioning properly when I violated the rule, I wanted to follow.
Probably those golint errors, asking me to name underscored variables to CamelCase, made me do the same with package name.

Sorry, my fault. Feeling apologetic.

But a lesson learned.

I should have shown it to someone before really moving ahead with that desicion.

Thanks @shurcooL, for pointing this out.

So now, can somebody please suggest me, what to name it?
Is geopattern fine? It doesn't feel good as a single word though.

from awesome-go.

dmitshur avatar dmitshur commented on May 8, 2024

I think geopattern is fine. I am not a huge fan of it, but that's the recommended style.

from awesome-go.

pravj avatar pravj commented on May 8, 2024

Yeah! I'm also not a fan of this convention.
But I renamed it to geopattern as you suggested, seems like it was the only option.

All this, resulted in a nice version message though. 😄

v1.4.1 - The Namesake

Made a pull request #306 for it.

Thanks for the help everyone.

from awesome-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.