Comments (4)
@nickasd thanks for checking in! I like the enum approach better, but I prefer to stay up to date with CreateAPI. In other words, please go ahead with the PR! If there's breaking changes, we can do a major version bump 👌
from appstoreconnect-swift-sdk.
I'll make the PR very soon. Just two more points I forgot to mention.
- Is there a specific reason why
.create-api.yml
is a hidden file? At the beginning I was looking for a.yml
file where theCreateAPI
settings were stored, but since the file is hidden I couldn't find it in the Finder or in Xcode, so I had to find out what the path was by looking atPlugins/CreateAPI/Plugin.swift
. I think making it visible by removing the leading period would make it easier for a new developer to find their way around the code. - Is it OK if I rename
app_store_connect_api_2.3_openapi.json
toapp_store_connect_api.json
? The2.3
version number in the file name is currently wrong anyway. One would always have to think about updating the filename each time the API file is updated as well.
from appstoreconnect-swift-sdk.
@nickasd both suggestions make totally sense to me!
from appstoreconnect-swift-sdk.
This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.
from appstoreconnect-swift-sdk.
Related Issues (20)
- How to use APIEndPoint.V2 Create inAppPurchases HOT 1
- How to use Create an In-App Purchase Review Screenshot HOT 2
- Add new device UDID failed HOT 2
- Error when tvOS 16.0 is selected as target HOT 1
- Example build error: Call can throw, but errors cannot be thrown out of a property initializer HOT 4
- InAppPurchasePriceScheduleCreateRequest fails when an in-app purchase has a different territory other than US. HOT 1
- Add other apis HOT 1
- AppStoreConnect API 2.3 Update Content Release One Version HOT 1
- Loading all of pricePoints HOT 2
- Add xrOS to enum Platform HOT 2
- Random crashes at JWTRequestsAuthenticator.adapt(_:) HOT 4
- Too Many Requests 429 HOT 5
- `CiGitUser.avatarUrl` fails to decode an empty string HOT 1
- More recent version HOT 4
- Vanished tag/release 3.0.0 HOT 1
- Device entity status enum missing PROCESSING HOT 1
- New case in UserRole/FilterRoles causing failure in decoder HOT 4
- Invalid String value DEVELOPER_ID_APPLICATION_G2 HOT 2
- `CiGitUser.avatarUrl` fails to decode an empty string HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from appstoreconnect-swift-sdk.