Coder Social home page Coder Social logo

Comments (4)

AvdLee avatar AvdLee commented on June 16, 2024

@nickasd thanks for checking in! I like the enum approach better, but I prefer to stay up to date with CreateAPI. In other words, please go ahead with the PR! If there's breaking changes, we can do a major version bump 👌

from appstoreconnect-swift-sdk.

nickasd avatar nickasd commented on June 16, 2024

I'll make the PR very soon. Just two more points I forgot to mention.

  1. Is there a specific reason why .create-api.yml is a hidden file? At the beginning I was looking for a .yml file where the CreateAPI settings were stored, but since the file is hidden I couldn't find it in the Finder or in Xcode, so I had to find out what the path was by looking at Plugins/CreateAPI/Plugin.swift. I think making it visible by removing the leading period would make it easier for a new developer to find their way around the code.
  2. Is it OK if I rename app_store_connect_api_2.3_openapi.json to app_store_connect_api.json? The 2.3 version number in the file name is currently wrong anyway. One would always have to think about updating the filename each time the API file is updated as well.

from appstoreconnect-swift-sdk.

AvdLee avatar AvdLee commented on June 16, 2024

@nickasd both suggestions make totally sense to me!

from appstoreconnect-swift-sdk.

github-actions avatar github-actions commented on June 16, 2024

This issue is stale because it has been open for 30 days with no activity. Remove the Stale label or comment or this will be closed in 10 days.

from appstoreconnect-swift-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.