Fallback still starts the container with compose? about pytest-docker

[AndreLouisCaron]

why still check if docker is available and then ignore what the user configured?

The intent here is that localhost is supported as a fallback mechanism. It's not "disable Docker", it's "try Docker and resort to localhost when necessary".

My impression from the wording around docker_allow_fallback would be that if it returns True it doesn't try to run anything with Compose at all and just returns localhost:port.

I agree that the wording in the README does not accurately describe what this feature does. I will try to updated it to better reflect how the feature works.

If the current behaviour is a problem for you, I'd consider a contribution that adds a "localhost only" mode.

Ideally, this should be a user preference (e.g. enabled using an environment variable), not a project preference.

[daenney]

Awesome, thanks for the clarification. I'll see if I can come up with a PR to make this configurable.

[butla]

@AndreLouisCaron What's the usecase for the fallback? I'm not getting why use pytest-docker if you don't have Docker.

[AndreLouisCaron]

­@butla It was meant as a crutch while converting a bunch of projects from a prehistoric database installer setup to a Docker-based test runner. We needed to support the same test suite with both Docker and non-Docker setups while we onboarded a bunch of people to the new Docker workflow.

I don't expect anyone to rely on this anymore, but I never saw removing this as time well spent either :-)

[butla]

@AndreLouisCaron Ok, thanks for clarification :-)