Coder Social home page Coder Social logo

"Special" hull color bugs about avara HOT 3 CLOSED

avaraline avatar avaraline commented on July 23, 2024
"Special" hull color bugs

from avara.

Comments (3)

rherriman avatar rherriman commented on July 23, 2024

I managed to fix the issues I reported above, but it was at the expense of the head color replacement. I now believe CBSPPart::ReplaceColor may not working as intended. We usually see it written as ReplaceColor(kMarkerColor, ...) which suggests that it is meant to replace the color for any polygon that is or was originally set to kMarkerColor. Right now, ReplaceColor is naïve and only applies to polygons that currently match the first parameter.

from avara.

rherriman avatar rherriman commented on July 23, 2024

I have since confirmed that CBSPPart::ReplaceColor is meant to behave in the way I described above by examining the original source. I intend on fixing the implementation myself, which I anticipate will resolve #3 as well as other small issues not formally catalogued at the moment.

from avara.

rherriman avatar rherriman commented on July 23, 2024

The problem persists even after #14, the issue being that CWalkerActor removes, replaces, and modifies the hull head color after SetSpecialColor is called. Need to either change the way special colors are implemented (and possibly alter the API just introduced in #14) or figure out how to fix CWalkerActor (and determine why it is doing what it is doing in the first place).

from avara.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.