`.ifError()` name is misleading about ava

[sindresorhus]

This is just inherited from the Node.js assert module.
Can you bring this up on the Node.js issue tracker first?

That assert method is pretty irrelvant with promises though.

[alebelcor]

I see, but looking at the assert documentation it states that ifError "throws value if value is truthy".

If I got that right I think AVA's ifError is inverted. It throws the value if it's falsy.

[Qix-]

Can you write a quick test case @alebelcor?

[floatdrop]

@Qix- ava have test case for this.

@alebelcor judging by test case ifError behaves correctly (throws, if value is truthy - double negative is always tough, thou).

[alebelcor]

OK, then (unless I'm mistaken) this just means that the readme.md is inaccurate.

It should read:

.ifError(error, [message])

Asserts that error is truthy.

[floatdrop]

Asserts that error is truthy.

Well, no. It asserts that error is falsy. It throws if error is truthy.

[sindresorhus]

@alebelcor If you have any good suggestions for a better name we might consider adding an alias, but I don't really care much tbh, as the future is promises and async functions which makes this assert method moot.

[sindresorhus]

Related: nodejs/node#3398