Coder Social home page Coder Social logo

Comments (3)

JWhitleyWork avatar JWhitleyWork commented on August 26, 2024 1

Yeah, I did copy this from kvaser_interface. However, the naming depends on whether you're looking at the data from the point of view of the ROS user or from the sensor. If you're coming from the sensor's point of view, sent would be data being sent from the sensor and received would be data received by the sensor. However, if you're looking at it from the point of view of the ROS user, sent would be data sent to the sensor while received would be data received from the sensor. While I agree that can_tx and can_rx might be backward, I still think they could be more precise.

To make it completely unambiguous, how do you feel about to_can and from_can or to_bus and from_bus?

from ros2_socketcan.

JWhitleyWork avatar JWhitleyWork commented on August 26, 2024 1

Changed to to_can_bus and from_can_bus in 468719f.

from ros2_socketcan.

kenji-miyake avatar kenji-miyake commented on August 26, 2024

@JWhitleyWork I agree with you.
For the people who are familiar with CAN, tx and rx are fine, but others can't understand easily.
In addition, tx and rx cause the point-of-view problem, so I think there are better namings.

To make it completely unambiguous, how do you feel about to_can and from_can or to_bus and from_bus?

I think to_can and fron_can are ambiguous because the ROS message is can_msgs.
to_bus and from_bus (or to_can_bus and from_can_bus?) seem good to me!

from ros2_socketcan.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.