Coder Social home page Coder Social logo

Comments (16)

kenji-miyake avatar kenji-miyake commented on July 28, 2024 1

@xmfcx Thank you for your comment! 😄

Why not https://readthedocs.org/ ?

Yes, Read the Docs can be a candidate.

IMO,

(I've never heard of mkdocs before)

It's very widely used!

from autoware-documentation.

xmfcx avatar xmfcx commented on July 28, 2024 1

@kenji-miyake

on the other hand looks so spaced out, empty and incomplete.

Could you show the points you have concerns, in a picture like this? Are the red rectangle areas what you concerned?

Screenshot from 2022-01-12 19-42-33

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on July 28, 2024

We'll set up mkdocs-material for this repository as well and try to prepare the equivalent documents as Autoware.Auto.

from autoware-documentation.

xmfcx avatar xmfcx commented on July 28, 2024

Why not https://readthedocs.org/ ? (I've never heard of mkdocs before)

(ROS2 uses it and it is also fast and beautiful https://docs.ros.org/en/rolling/index.html )

from autoware-documentation.

mitsudome-r avatar mitsudome-r commented on July 28, 2024

Some of the features that we want:

  • We want have searching result to be shown in the separate page like in read the docs
  • We should have versioning of documents

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on July 28, 2024

We want have searching result to be shown in the separate page like in read the docs

This is available by this option if we use readthedocs theme.
https://www.mkdocs.org/dev-guide/themes/#include_search_page

image

However, material theme seems not supporting this.
https://github.com/squidfunk/mkdocs-material/blob/727f94f8676fea43a182703a558f08a19b6ceccb/mkdocs.yml#L47

@xmfcx Is this feature mandatory? If we'd like to simply share the URL, it's supported by material theme.
https://squidfunk.github.io/mkdocs-material/setup/setting-up-site-search/?q=test
image

We should have versioning of documents

This is available now by mike.

from autoware-documentation.

xmfcx avatar xmfcx commented on July 28, 2024

I like readthedocs theme more actually. The material theme feels more modern but incomplete, spaced out.

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on July 28, 2024

@xmfcx Thank you, I see. But I love the material theme.
So, since it depends on the person, I think it's better to decide by a questionnaire or something. Is that okay for you?

If it's okay, I'll send a PR for the comparison after I add some content.

Also, there is one more thing I'd like to clarify.
Is it okay for you to use MkDocs? I mean, are you concerned only about the theme?
Or do you want to use other tools such as Sphinx, mdBook, etc?

from autoware-documentation.

xmfcx avatar xmfcx commented on July 28, 2024

@xmfcx Thank you, I see. But I love the material theme. So, since it depends on the person, I think it's better to decide by a questionnaire or something. Is that okay for you?

If you want, you can arrange one in the slack. To me https://docs.ros.org/en/rolling/index.html looks like the perfect documentation style for me. It is structured and solid. https://iceoryx.io/v1.0.1/getting-started/what-is-iceoryx/ on the other hand looks so spaced out, empty and incomplete.

If it's okay, I'll send a PR for the comparison after I add some content.

I don't think that's necessary, we know how both look like.

Also, there is one more thing I'd like to clarify. Is it okay for you to use MkDocs? I mean, are you concerned only about the theme? Or do you want to use other tools such as Sphinx, mdBook, etc?

https://docs.readthedocs.io/en/stable/intro/getting-started-with-sphinx.html#using-markdown-with-sphinx this I think is our best bet since it has the markdown that we want to use and core readthedocs that I like.

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on July 28, 2024

on the other hand looks so spaced out, empty and incomplete.

Could you show the points you have concerns, in a picture like this?
Are the red rectangle areas what you concerned?

image

I don't think that's necessary, we know how both look like.

Yes, but I guess we need to compare not only the looking but also some features.
Material theme has many customizable features.

features:
- navigation.expand
- navigation.indexes
- navigation.instant
- navigation.sections
- navigation.tabs
- navigation.tabs.sticky
- navigation.top
favicon: assets/images/autoware-foundation.png
icon:
logo: fontawesome/solid/car
repo: fontawesome/brands/github
language: en
palette:
- scheme: default
primary: white
toggle:
icon: material/weather-sunny
name: Switch to dark mode
- scheme: slate
primary: grey
toggle:
icon: material/weather-night
name: Switch to light mode

You can test the features here.
https://squidfunk.github.io/mkdocs-material/setup/setting-up-navigation/

https://docs.readthedocs.io/en/stable/intro/getting-started-with-sphinx.html#using-markdown-with-sphinx this I think is our best bet since it has the markdown that we want to use and core readthedocs that I like.

As mentioned here, my concern is whether we can use the full features, I'm not sure about that and it takes some time to learn that.


Anyway, as a result of https://gitlab.com/autowarefoundation/autoware-foundation/-/issues/198, we agreed to start with MkDocs and consider moving to Read the Docs later.

from autoware-documentation.

alexandrx avatar alexandrx commented on July 28, 2024

@kenji-miyake Regarding arguments in favour of mkdocs-materials or other, you could help us listing up some key open source projects using it. In particular, if ROS community also use it as main documentation platform, or there is a trend to, then there will not be many objections.

Similar to Doxygen, it seems capable of rendering LaTeX, so documentation involving some mathematical terms, diagrams, etc., should be possible.

from autoware-documentation.

xmfcx avatar xmfcx commented on July 28, 2024

@kenji-miyake Regarding arguments in favour of mkdocs-materials or other, you could help us listing up some key open source projects using it. In particular, if ROS community also use it as main documentation platform, or there is a trend to, then there will not be many objections.

He mentioned them in this comment above: #4 (comment)

from autoware-documentation.

stale avatar stale commented on July 28, 2024

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on July 28, 2024

@xmfcx Do you think we can close this and create a new issue if necessary in the future?

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on July 28, 2024

I assume yes.
#4 (comment)

from autoware-documentation.

kenji-miyake avatar kenji-miyake commented on July 28, 2024

Another user of MkDocs Material.
https://github.com/pi-hole/pi-hole
https://docs.pi-hole.net/

from autoware-documentation.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.