Comments (3)
Greg and I were hoping that this would be a good opportunity to use a GitHubReleasesInfoProvider processor I wrote some time ago, which was not fully-baked at the time to include in AutoPkg.
Just committed to an alternate munkitools-github branch in this repo, is an updated munkitools2 recipe that can selectively filter out the prereleases:
122c252
It uses a more capable and robust version of this GitHub processor. It also demonstrates filtering the release asset by a regex, which means the same processor could be used to get the 1.0 releases which came in a dmg.
However, because it replaces our previous custom processor, it doesn't currently let you override this same recipe to fetch from munkibuilds.org as the previous ones did.
I'd rather not break the existing recipes for everyone, as well as not require one to keep two different overrides with all the various displayname
/description
/etc. fields - you would wind up needing one for "stable" and one for the autobuilds, unless you just pick autobuilds and are careful about which releases you promote.
Perhaps it might be possible to keep the custom behavior by subclassing the GitHub processor and adding back in our hack we had for changing the behavior based on the URL, or at least just pass the url through if DOWNLOAD_URL
was set by an override.
from recipes.
Also, I should note that the GitHubReleasesInfoProcessor doesn't yet do sufficient validation of the keys in the JSON response.
While the few keys we use should always be there, there will also need to be an additional validation performed up front in case the API happens to be buggy at the time of an AutoPkg run.
from recipes.
Recipes were split up into two, see for more discussion:
https://groups.google.com/d/topic/autopkg-discuss/j0nI3rYgEzQ/discussion
from recipes.
Related Issues (20)
- AdobeReaderURLProvider providing invalid URL HOT 7
- AdobeReaderDC.download.recipe fails because of mismatch in authority names HOT 1
- Praat.download: CodeSignatureVerifier fails due to outdated designated requirement string HOT 3
- Acrobat Adobe Reader DC has been reverted to Acrobat Adobe Reader (DC removed) HOT 4
- Wrong pattern in line 189 munkitools.munki.recipe HOT 1
- Error with GoogleChrome.pkg recipe HOT 3
- MSAutoUpdate.download.recipe - processor MSOfficeMacURLandUpdateInfoProvider can't be found HOT 1
- XQuartz sparkle URL has changed HOT 3
- XQuartz download recipe pointing to old Sparkle feed
- com.github.autopkg.munki.MSTeams pulls an old version HOT 2
- com.github.autopkg.munki.MSTeams pulls old version HOT 3
- Feature request - munkitools6 recipe should support the MacAdmins signed releases HOT 1
- FR - MSOffice - MSOfficeMacURLandUpdateInfoProvider.py - BASE_URL change suggestion HOT 4
- Errant plist data in metadata for MSCompanyPortal download recipe causes autopg run to abort
- AdobeReader.pkg.recipe breaks package with Ventura
- Evernote.download.recipe - Processor: URLDownloader: Error: curl: (22) The requested URL returned error: 404 HOT 3
- Evernote.download.recipe -- Download URL has changed (again) HOT 1
- Dropbox download/munki recipes every so often appears to install beta version instead of production version
- Handbrake: incorrect file type is downloaded from GitHub
- package receipt not valid mechanism for Adobe Reader HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from recipes.