VLC package recipe fails due to bogus RECIPE_DIR variable, quick fix about recipes

[timsutton]

RECIPE_DIR should be getting set and be substitutable like any other. It's working for me here with today's code from master.

You don't perhaps have RECIPE_DIR set manually (to /private/tmp) in your prefs?

~/git/github/autopkg/Code/autopkg run -vvv VLC.pkg
Processing VLC.pkg...
{'AUTOPKG_VERSION': u'0.2.7',
 u'MUNKI_REPO': u'/Volumes/munki_repo',
 u'NAME': u'VLC',
 'PARENT_RECIPES': [u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC/VLC.download.recipe'],
 'RECIPE_CACHE_DIR': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC',
 'RECIPE_DIR': u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC',
 u'RECIPE_OVERRIDE_DIRS': [u'/Users/tsutton/git/cda-autopkg-overrides'],
 'RECIPE_PATH': u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC/VLC.pkg.recipe',
 u'RECIPE_REPOS': {u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.keeleysam-recipes': {
    URL = "https://github.com/autopkg/keeleysam-recipes";
},
                   u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes': {
    URL = "https://github.com/autopkg/recipes";
},
                   u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.timsutton-recipes': {
    URL = "https://github.com/autopkg/timsutton-recipes";
},
                   u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.hjuutilainen.autopkg-recipes': {
    URL = "https://github.com/hjuutilainen/autopkg-recipes";
},
                   u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.jessepeterson.autopkg-recipes': {
    URL = "https://github.com/jessepeterson/autopkg-recipes";
}},
 u'RECIPE_SEARCH_DIRS': [u'.',
                         u'~/Library/AutoPkg/Recipes',
                         u'/Library/AutoPkg/Recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.hjuutilainen.autopkg-recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.jessepeterson.autopkg-recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.keeleysam-recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.timsutton-recipes'],
 'verbose': 3}
SparkleUpdateInfoProvider
{'Input': {'appcast_url': u'http://update.videolan.org/vlc/sparkle/vlc-intel64.xml'}}
SparkleUpdateInfoProvider: Version retrieved from appcast: 2.1.2
SparkleUpdateInfoProvider: Found URL http://get.videolan.org/vlc/2.1.2/macosx/vlc-2.1.2.dmg
{'Output': {'additional_pkginfo': {},
            'url': 'http://get.videolan.org/vlc/2.1.2/macosx/vlc-2.1.2.dmg'}}
URLDownloader
{'Input': {'filename': u'VLC.dmg',
           'url': 'http://get.videolan.org/vlc/2.1.2/macosx/vlc-2.1.2.dmg'}}
URLDownloader: Item at URL is unchanged.
URLDownloader: Using existing /Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg
{'Output': {'download_changed': False,
            'etag': '',
            'last_modified': '',
            'pathname': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg'}}
EndOfCheckPhase
{'Input': {}}
{'Output': {}}
AppDmgVersioner
{'Input': {'dmg_path': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg'}}
AppDmgVersioner: Mounted disk image /Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg
AppDmgVersioner: BundleID: org.videolan.vlc
AppDmgVersioner: Version: 2.1.2
{'Output': {'app_name': u'VLC.app',
            'bundleid': u'org.videolan.vlc',
            'version': u'2.1.2'}}
PkgRootCreator
{'Input': {'pkgdirs': {
    Applications = 0775;
},
           'pkgroot': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC'}}
PkgRootCreator: Created /Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC
PkgRootCreator: Creating Applications
PkgRootCreator: Created /Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC/Applications
{'Output': {}}
Copier
{'Input': {'destination_path': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC/Applications/VLC.app',
           'source_path': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg/VLC.app'}}
Copier: Mounted disk image /Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg
Copier: Copied /private/tmp/dmg.WL2vss/VLC.app to /Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC/Applications/VLC.app
{'Output': {}}
PkgInfoCreator
{'Input': {'infofile': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/PackageInfo',
           'pkgroot': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC',
           'pkgtype': u'flat',
           'template_path': u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC/PackageInfoTemplate',
           'version': u'2.1.2'}}
{'Output': {}}
PkgCreator
{'Input': {'pkg_request': {
    chown =     (
                {
            group = admin;
            path = Applications;
            user = root;
        }
    );
    id = "org.videolan.vlc.pkg";
    options = "purge_ds_store";
    pkgdir = "/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC";
    resources = "/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC/Resources";
}}}
PkgCreator: Connecting
PkgCreator: Sending packaging request
PkgCreator: Disconnecting
{'Output': {'pkg_path': '/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC-2.1.2.pkg'}}
{'AUTOPKG_VERSION': u'0.2.7',
 u'MUNKI_REPO': u'/Volumes/munki_repo',
 u'NAME': u'VLC',
 'PARENT_RECIPES': [u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC/VLC.download.recipe'],
 'RECIPE_CACHE_DIR': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC',
 'RECIPE_DIR': u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC',
 u'RECIPE_OVERRIDE_DIRS': [u'/Users/tsutton/git/cda-autopkg-overrides'],
 'RECIPE_PATH': u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC/VLC.pkg.recipe',
 u'RECIPE_REPOS': {u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.keeleysam-recipes': {
    URL = "https://github.com/autopkg/keeleysam-recipes";
},
                   u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes': {
    URL = "https://github.com/autopkg/recipes";
},
                   u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.timsutton-recipes': {
    URL = "https://github.com/autopkg/timsutton-recipes";
},
                   u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.hjuutilainen.autopkg-recipes': {
    URL = "https://github.com/hjuutilainen/autopkg-recipes";
},
                   u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.jessepeterson.autopkg-recipes': {
    URL = "https://github.com/jessepeterson/autopkg-recipes";
}},
 u'RECIPE_SEARCH_DIRS': [u'.',
                         u'~/Library/AutoPkg/Recipes',
                         u'/Library/AutoPkg/Recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.hjuutilainen.autopkg-recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.jessepeterson.autopkg-recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.keeleysam-recipes',
                         u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.timsutton-recipes'],
 'additional_pkginfo': {},
 'app_name': u'VLC.app',
 u'appcast_url': u'http://update.videolan.org/vlc/sparkle/vlc-intel64.xml',
 'bundleid': u'org.videolan.vlc',
 u'destination_path': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC/Applications/VLC.app',
 u'dmg_path': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg',
 'download_changed': False,
 'etag': '',
 u'filename': u'VLC.dmg',
 u'infofile': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/PackageInfo',
 'last_modified': '',
 'pathname': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg',
 'pkg_path': '/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC-2.1.2.pkg',
 u'pkg_request': {
    chown =     (
                {
            group = admin;
            path = Applications;
            user = root;
        }
    );
    id = "org.videolan.vlc.pkg";
    infofile = "/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/PackageInfo";
    options = "purge_ds_store";
    pkgdir = "/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC";
    pkgname = "VLC-2.1.2";
    pkgroot = "/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC";
    pkgtype = flat;
    resources = "/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC/Resources";
    scripts = "";
    version = "2.1.2";
},
 u'pkgdirs': {
    Applications = 0775;
},
 u'pkgname': u'VLC-2.1.2',
 u'pkgroot': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC',
 u'pkgtype': u'flat',
 u'source_path': u'/Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/downloads/VLC.dmg/VLC.app',
 u'template_path': u'/Users/tsutton/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes/VLC/PackageInfoTemplate',
 'url': 'http://get.videolan.org/vlc/2.1.2/macosx/vlc-2.1.2.dmg',
 'verbose': 3,
 'version': u'2.1.2'}
Receipt written to /Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/receipts/VLC-receipt-20140107-104726.plist

The following packages were built:
    Identifier               Version          Pkg path
    ----------               -------          --------
    org.videolan.vlc.pkg     2.1.2            /Users/tsutton/Library/AutoPkg/Cache/com.github.autopkg.pkg.VLC/VLC-2.1.2.pkg

[arubdesu]

Nope, so this is a head-scratcher. @golbiga did experience the same symptom... https://gist.github.com/golbiga/8274348

$defaults read com.github.autopkg { "API_PASSWORD" = apiPassword; "API_USERNAME" = apiUser; "JSS_REPO" = "/Volumes/JSS_Dist_Point/Packages"; "JSS_URL" = "https://my.jss.test:8443"; "MUNKI_REPO" = "/Users/Shared/repo"; "RECIPE_REPOS" = { "/Users/318admin/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes" = { URL = "http://github.com/autopkg/recipes.git"; }; }; "RECIPE_SEARCH_DIRS" = ( ".", "~/Library/AutoPkg/Recipes", "/Library/AutoPkg/Recipes", "/Users/318admin/Library/AutoPkg/RecipeRepos/com.github.autopkg.recipes" ); }

[timsutton]

Ok. If the same thing happens with VLC.pkg, can you paste full -vvv output?

[golbiga]

The same does not happen when I do just the VLC.pkg.

[gregneagle]

So when does it happen? Confused now.

On Jan 7, 2014, at 11:52 AM, Allen Golbig [email protected] wrote:

The same does not happen when I do just the VLC.pkg.

—
Reply to this email directly or view it on GitHub.

[arubdesu]

We had been using my jss.recipes. But, with the newest autopkg release this is totally working for me again now... so maybe ok to close?

[golbiga]

It's still failing for me, even when running the latest release 0.2.7. My gist with an output of a failed and successful run when removing %RECIPE_DIR% from PackageInfoTemplate is here, https://gist.github.com/golbiga/8306088.

[timsutton]

Now it makes sense: the VLC.jss recipe doesn't have a PackageInfoTemplate file.

The original VLC recipes work because %RECIPE_DIR%/PackageInfoTemplate exists, but it doesn't in the case of the VLC.jss recipe. AutoPkg won't magically merge the RECIPE_DIRs of child and parent recipes.

[golbiga]

Copying the the PackageInfoTemplate into the jssRecipes Repo solved the issue. Thanks for the assistance!