TextMate2 postinstall_script should copy 'mate' not symlink about recipes

[timsutton]

I don't think it really matter practically whether something's copied or a symlink because it's being done for every version, so this seems fine.

However, on my machine, TextMate doesn't complain if the file is a symlink. Are you sure it's not complaining for some other reason? In other words, does it say that's why it's asking for admin rights, and does it copy the file (overwriting the symlink) if you enter an admin password?

FWIW, I've tested on my machine that the symlink can be either owned by my regular user or root:wheel. TextMate's preferences report that shell support is installed.

[jps3]

I had been preparing a detailed list of the steps I took, but thought I'd better retrace my steps from earlier today... And either something is behaving slightly differently, or I did something slightly different earlier. I would swear that earlier I had tested as non-admin user with symlink and as copy, and did not got prompt for admin creds with symlink of 'mate', but did not get prompt with copy of 'mate' in /usr/local/bin... Just tested on a different lab machine as non-admin and now, either way I get prompt for admin creds on first launch and I cannot yet figure out what TextMate is trying to do that it's asking for this.

Sorry for bother! If I figure this out, can add comment here if you like (I know not same issue technically, but perhaps helpful?)

[jps3]

Before I forget, this is dealing with TextMate 2.0-alpha.9487

Here are some ARD screenshots of the remote/lab computer of steps I was taking:

• Before logging in had done rm -fr for non-admin user home folder I'd tested with, and recreated (createhomedir -c -u ), as well as /Applications/TextMate.app and /usr/local/bin/mate. I did this to try to start with a clean slate.
• I then ran Munki's managedsoftwareupdate which installed TextMate2. In this instance was my version of postinstall script which made copy of 'mate' rather than symlink (you can see it in the Finder window to the left).

• I was curious if there was any diagnostic output, so I ran the TextMate binary directly from the command line. The prompt for admin credentials had popped up and I had hit Esc or clicked cancel.
• What had made me think that 'cp' was required over symlink was the output you'll see at the bottom of the Terminal window, the line '/bin/cp -p ...' and what led to my original posting.

• After quitting TextMate.app, which in Terminal returned me to a command prompt.
• Out of curiosity, and as a sanity check, did a SHA256 hash check between 'mate' in /Applications/TextMate.app/Contents/Resources and /usr/local/bin. They're the same.

Note: I just repeated the first step after deleting /Users/ folder and createhomdir again, and erasing TextMate.app and 'mate' and reinstalling via Munki. This time I used stock autopkg recipe which created symlink. When prompted for admin credentials I did enter them (as opposed to prior Esc/Cancel) and symlink in /usr/local/bin was replaced with 'cp' copy of 'mate'! (Hrmm...)

[timsutton]

Sorry for the delay in dealing with this one. I was never able to get it to request auth due to the symlink, but just for reference here's what TextMate does currently to install the binary:

https://github.com/textmate/textmate/blob/274f73b7de3e7fd9ed67490cfc82cf6d22f9c44e/Frameworks/Preferences/src/TerminalPreferences.mm#L113-L140

Thanks for investigating!