Comments (7)
This might be related to #52 -- the issue hangs around even after you've switched back to the default style pack, as long as it's been changed at some point in the past -- it's due to my clunky code for the Customizer.
@claudiulodro do you remember if you switched the style pack at any point on this test site?
from newspack-theme.
Not sure. I should be getting my new computer today, so I'll give it a test on a clean slate and see.
from newspack-theme.
Thanks! (And yay new computer!! 🎉 )
from newspack-theme.
Just tested on the cleanest of new sites, and the issue still happens. It's not because I had a style pack and then removed it.
from newspack-theme.
Thanks for double-checking!
Dang, this could be a bigger issue than I thought.
from newspack-theme.
Did a little more digging into this, and it seems to def. be related to the style packs. If I remove add_action( 'customize_preview_init', array( $this, 'customize_preview' ) );
from Newspack_Style_Packs_Core
the customizer colors work great.
The underlying issue to me looks like style.css
is getting enqueued twice:
- Once normally
- Once by the style pack JS
The second enqueue (the one by style pack) overrides the customizer styles, since the styles all have the same specificity but the style pack loads style.css
after the customizer styles have been applied.
Closing this issue since it seems to be the same as #52. Hope this info helps! :)
from newspack-theme.
Yes -- thanks @claudiulodro!!
from newspack-theme.
Related Issues (20)
- Author Bio: Add user website HOT 2
- Print styles: Audit to review campaign/ad positions and make sure they're hidden HOT 7
- Display Tagline: Site sometimes does not respect setting in Customizer HOT 2
- Print styles: sticky headers and two column templates HOT 2
- Search Block: Display errors in WP 6.1 beta 3 HOT 5
- Pullquote Block: Font size larger in 6.1 HOT 2
- Simplified subpage header: add option to move hamburger menu
- ARIA IDs are not unique HOT 3
- Group block: Contents don't preview centred in editor when block is full-width HOT 2
- Add support for alternative Google Font source in the Typography panel
- Newspack Listings: Add option to set a default template HOT 1
- Buttons do not have an accessible name HOT 1
- ARIA IDs are not unique HOT 1
- Post not loading properly on mobile and desktop - poss AMP issue HOT 9
- Please Add Post View Count Feature in the Theme HOT 1
- AMP Issue when trying to validate AMP Settings HOT 1
- Hide Category Description HOT 1
- Use correct icon for Google news
- Subcategory showing as XML. HOT 2
- Add toggle to allow commenters' names to be shown below comments, instead of above them
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from newspack-theme.