Comments (4)
This may sound trivial but adding an explanation of what Tag ID, DFP ID, and Tag Name are andwhat format they should look (ca-pub-XXXXXXXXXXXXXXXX) like would help tremendously for people like this: http://wordpress.org/support/topic/how-to-get-the-tag-id-dfp-id-tag-name-from-adsense-google-admanager
(and people like me too)
I think it's nearly mandatory in the readme, but it'd also be nice inline on the config page (since large number of people won't read the readme)
from ad-code-manager.
@jb510 up for submitting a pull request for this?
from ad-code-manager.
I would, but I'm not familiar enough with Adsense/DoubleClick to be confident what those things are in each case (still trying to get this plugin working for the first time). When I get it functional and know what those things are, yes I'll definitely update my fork and put in a PR.
from ad-code-manager.
Closing this out as 0.4.3 0.5 was shipped, but have moved the documentation suggestion to #123.
from ad-code-manager.
Related Issues (20)
- any update on pushing 0.5x to wp repo? HOT 1
- Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP
- PHP 7 compatibility in MarkdownExtra_Parser
- PHP 7.4 deprecation warning HOT 1
- Add Settings Link to Plugin Row Actions
- Add check for post type when deleting ad codes
- Add an explanation of what Tag ID, DFP ID, and Tag Name are and what format they should look HOT 1
- Add WPORG deploy workflow
- Fix tests dependencies
- Fix internationalization in PHP strings
- Bump minimum PHP and WordPress versions
- Simplify / fix Contextual Help
- Refresh screenshots
- Properly document all action and filter hooks
- PHP 8.0 fatal error for unknown named parameter $is_singular HOT 3
- Update Screenshots for 4.3 HOT 1
- Strict standards errors HOT 1
- Non-existence of ad codes should be cached.
- action_acm_tag() has a flag to return instead of echo but you can't return out of do_action() HOT 1
- Native ads using DFP HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ad-code-manager.