If an ad tag doesn't need a URL, ignore whitelist checks about ad-code-manager

[rinatkhaziev]

Hey @tddewey,

What's the use case? E.g. Ad network/ ad platform, example ad code?

[tddewey]

Doubleclick for publishers, async tag. Each ad_tag_id outputs this:

        <!-- %tag_id% -->
        <div id='%div%' style='width:%width%px; height:%height%px;'>
            <script type='text/javascript'>
                googletag.cmd.push(function() { googletag.display('%div%'); });
            </script>
        </div>

Except for one ad_tag as a placeholder that, in the header, defines the configuration for all of them and adds some targeting variables that are set up in the ad code manager admin. I can paste up my full configuration if it'd help.

[rinatkhaziev]

@jeremyfelt what's your 3 cents on this one? I remember your gist with DFP JS config, i checked it but there's nothing regarding whitelisting url. May be we could introduce a filter like acm_no_url_in_tag to skip whitelist check
/cc @danielbachhuber

[danielbachhuber]

Why don't we just search for the URL token in the string and ignore the whitelist check if there isn't one?

[rinatkhaziev]

Totally!