Comments (15)
This would render the ad for preview?
from ad-code-manager.
Yep, that's what I was trying to say. I'll discuss with our designers, let's see what's their take on it. I envision modal window that shows all configured ad tag ids for specific ad code. (like, click preview in row actions, it pops the modal with all the different ad tags)
from ad-code-manager.
Cool, that would be neat.
from ad-code-manager.
this one is mine for 0.4
from ad-code-manager.
@rinatkhaziev still want to take a swing at this for v0.4?
from ad-code-manager.
@danielbachhuber Is there any tentative release date?
from ad-code-manager.
http://adcodemanager.wordpress.com/2013/02/28/and-im-back-into-it-lets-discuss-a/
from ad-code-manager.
@carldanley Can you look into this please? I think it'll take less for you time that it would've taken for me.
If not, I'll try to take care of it myself.
from ad-code-manager.
Sure, @rinatkhaziev. Is there more information concerning this modal and what it should look like? Has the 'preview' already been added? Just need a little more information to get started.
from ad-code-manager.
No requirements, but what I was envisioning is that when you hit a "Preview" row action it pops up a modal that renders all registered ad sizes. Rendering would happen in AJAX action. If you got a better idea - let's discuss it.
@jeremyfelt @carldanley @danielbachhuber
from ad-code-manager.
Will be able to look into this later this month. I'm heads down on a big site launch atm.
from ad-code-manager.
Punting this to v0.5
from ad-code-manager.
Is there a mockup or anything for this? Was thinking I can use something similar to the new WP modal ( in terms of UI ). Thoughts?
from ad-code-manager.
New WP modal sounds reasonable. There haven't been any mockups afaik
On Apr 16, 2013, at 5:11, Carl Danley [email protected] wrote:
Is there a mockup or anything for this? Was thinking I can use something similar to the new WP modal ( in terms of UI ). Thoughts?
—
Reply to this email directly or view it on GitHub.
from ad-code-manager.
Yes, there's no mocks. I can ask my UX/UI co-worker, but I agree with wp modal
from ad-code-manager.
Related Issues (20)
- any update on pushing 0.5x to wp repo? HOT 1
- Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP
- PHP 7 compatibility in MarkdownExtra_Parser
- PHP 7.4 deprecation warning HOT 1
- Add Settings Link to Plugin Row Actions
- Add check for post type when deleting ad codes
- Add an explanation of what Tag ID, DFP ID, and Tag Name are and what format they should look HOT 1
- Add WPORG deploy workflow
- Fix tests dependencies
- Fix internationalization in PHP strings
- Bump minimum PHP and WordPress versions
- Simplify / fix Contextual Help
- Refresh screenshots
- Properly document all action and filter hooks
- PHP 8.0 fatal error for unknown named parameter $is_singular HOT 3
- Update Screenshots for 4.3 HOT 1
- Strict standards errors HOT 1
- Non-existence of ad codes should be cached.
- action_acm_tag() has a flag to return instead of echo but you can't return out of do_action() HOT 1
- Native ads using DFP HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ad-code-manager.