Comments (8)
Yep, I saw this as I was doing the final review and was somewhat confused as to the purpose of the second.
from ad-code-manager.
How about this?
https://gist.github.com/ed088bc8bd5a8a68cdee
If you have more elegant ideas I would be thrilled to hear 'em :)
from ad-code-manager.
Bumping to v0.2.2
from ad-code-manager.
This is related to #34
from ad-code-manager.
Bumping to v0.2.3
from ad-code-manager.
Is it necessary to have anything other than acm_list_table_columns? acm_provider_columns was only used in the provider definitions before, and only one provider can be used at a time, so it seems that it kind of works itself out.
Unless I'm missing something completely, which is entirely possible. :)
from ad-code-manager.
Well, given the nature of ad providers and that one platform could have many flavors, we need the ability to filter ad_code_args and then reflect it in WP_List_table columns. It would be nice to have one filter taking care of it, this might need some love: https://github.com/Automattic/Ad-Code-Manager/blob/develop/common/lib/acm-wp-list-table.php#L26
Make sense?
from ad-code-manager.
I think my vote is to keep two filters, but have the values for 'acm_list_table_columns' based on 'acm_provider_columns' unless you explicitly decide to change which columns show. 'acm_provider_columns' could be better named though.
from ad-code-manager.
Related Issues (20)
- any update on pushing 0.5x to wp repo? HOT 1
- Deprecated: Methods with the same name as their class will not be constructors in a future version of PHP
- PHP 7 compatibility in MarkdownExtra_Parser
- PHP 7.4 deprecation warning HOT 1
- Add Settings Link to Plugin Row Actions
- Add check for post type when deleting ad codes
- Add an explanation of what Tag ID, DFP ID, and Tag Name are and what format they should look HOT 1
- Add WPORG deploy workflow
- Fix tests dependencies
- Fix internationalization in PHP strings
- Bump minimum PHP and WordPress versions
- Simplify / fix Contextual Help
- Refresh screenshots
- Properly document all action and filter hooks
- PHP 8.0 fatal error for unknown named parameter $is_singular HOT 3
- Update Screenshots for 4.3 HOT 1
- Strict standards errors HOT 1
- Non-existence of ad codes should be cached.
- action_acm_tag() has a flag to return instead of echo but you can't return out of do_action() HOT 1
- Native ads using DFP HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ad-code-manager.