Comments (4)
Hi @MarcelPa, thanks for submitting this issue.
This behavior is intended - mostly just to avoid ambiguity even if losing in ergonomics. But just to avoid surprises in the API and make necessary clarifications/changes I would like to ask for your opinion:
What was the expected behavior when returning empty strings? Should they be stored as empty log entries? Ignored? Something else?
This knowledge is very important because we plan to add support for structured logs in the near future, i.e. you will be able to log arbitrary hashes (dicts? maps?). There will be multiple cases similar to the one with empty strings and proper handling should go along user expectations.
As for general Remote Agent API fragility - there is room to grow, working on it (all the changes will be backward-compatible).
Thank you!
Vidas
from active_workflow.
Hey @vidas , great question actually, I did not think about that.
I think I would prefer empty log entries to appear, which would have made me fixing me agent the way I did anyway. I can see that this would add ambiguity to the logs of ActiveWorkflow (especially in the case, where an ActiveWorkflow user is not equal to the developer of the remote agent). To find some middle ground: mention this behaviour in the RemoteAPI Docs and add a more explicit error message (as a Python dev, my time to find the actual problem was quite long :-D )
Structured logs sound interesting. Do you plan to add logging levels? I think that could make debugging agents in a production environment easier (again, thats a devs perspective).
Cheers
Marcel
from active_workflow.
Hi @MarcelPa.
Logging levels are already partially implemented - having log
and error
is one aspect of that, but I agree that a user should be able to select an arbitrary log level. More work is necessary on the frontend/API side of the thing to make use of the logging level. This is very much in the plans.
Thank you!
Vidas
from active_workflow.
Hello, @MarcelPa,
The Remote Agent documentation has been updated (a little while ago) to mention that empty strings are not allowed in log messages as you suggested. There is also a helper Python library now that one could use when writing agents ActiveWorkflow Agent Python.
Thank you again for submitting the issue.
from active_workflow.
Related Issues (12)
- docker workflow isn't working HOT 1
- Security concern HOT 1
- Send array in Post Agent HOT 7
- AGPL-3.0-only HOT 2
- SMTP configuration
- Contribute back to Huginn? HOT 4
- Using alpine image HOT 2
- How to use credentials? HOT 6
- TCP Timeout for Remote Agents / Async HTTP HOT 1
- Updating Remote Agent information/description HOT 4
- Application freezes when run with docker-compose since v0.9.9 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from active_workflow.