Coder Social home page Coder Social logo

Comments (11)

apiad avatar apiad commented on June 29, 2024 2

@AnshuTrivedi if you want to do it, let me know so we can mark it as wip and assign it to you 😉

from autogoal.

AnshuTrivedi avatar AnshuTrivedi commented on June 29, 2024 1

I think it would be better to create task list for all unit tests for examples in one issue (just suggestion)
Any one willing to contribute may write even single unit test.

from autogoal.

apiad avatar apiad commented on June 29, 2024 1

@apiad do have to replace ConsoleLogger and a ProgressLogger or MemoryLogger and a ConsoleLogger ?
or all three ?

Just ConsoleLogger and ProgressLogger.

from autogoal.

apiad avatar apiad commented on June 29, 2024 1

I think it would be better to create task list for all unit tests for examples in one issue (just suggestion)
Any one willing to contribute may write even single unit test.

We have #26 issue for tracking this... If you have any idea how can it be better organized, just go to that issue and let us know. We are open to any suggestion 😄

from autogoal.

EEstevanell avatar EEstevanell commented on June 29, 2024 1

@apiad sure! I will look into this right away

from autogoal.

AnshuTrivedi avatar AnshuTrivedi commented on June 29, 2024

@apiad May you help me explaining little more for better understanding what have to do?
I would love to contribute !

from autogoal.

apiad avatar apiad commented on June 29, 2024

Sure! The examples in the docs/examples folder have this line somewhere:

loggers = [ProgressLogger(), ConsoleLogger(), logger]

Instead of instantiating a ConsoleLogger and a ProgressLogger we can replace those two by a single RichLogger which is in autogoal.search. This is a new logger that shows pretty printed stuff with syntax highlight, colors, etc., and is used in the CLI.

What we want is to go over all examples, and wherever there is a MemoryLogger and a ConsoleLogger replace those by a single RichLogger.

And of course run them and make sure there are no obvious errors. Sadly we don't have unit tests for examples yet...

from autogoal.

AnshuTrivedi avatar AnshuTrivedi commented on June 29, 2024

@AnshuTrivedi if you want to do it, let me know so we can mark it as wip and assign it to you 😉

Sure !
Thanks.

from autogoal.

AnshuTrivedi avatar AnshuTrivedi commented on June 29, 2024

Sure! The examples in the docs/examples folder have this line somewhere:

loggers = [ProgressLogger(), ConsoleLogger(), logger]

Instead of instantiating a ConsoleLogger and a ProgressLogger we can replace those two by a single RichLogger which is in autogoal.search. This is a new logger that shows pretty printed stuff with syntax highlight, colors, etc., and is used in the CLI.

What we want is to go over all examples, and wherever there is a MemoryLogger and a ConsoleLogger replace those by a single RichLogger.

And of course run them and make sure there are no obvious errors. Sadly we don't have unit tests for examples yet...

@apiad do have to replace ConsoleLogger and a ProgressLogger or MemoryLogger and a ConsoleLogger ?
or all three ?

from autogoal.

apiad avatar apiad commented on June 29, 2024

Hey @AnshuTrivedi, I was just wondering if you're still interested in this issue? It's OK if you're busy with something else, or if you need any help, just let us know!

Thanks :)

from autogoal.

apiad avatar apiad commented on June 29, 2024

@EEstevanell would you mind taking over this issue?

from autogoal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.