Comments (1)
I forked the repo and was planning to make the changes to go into a PR. Before doing that I ran the test script from package.json and it showed two failures:
2 failing 1) samlp response signing signResponse=true and signAssertion=true when invalid signing key is used should return an error: Uncaught AssertionError: expected 'error:1E08010C:DECODER routines::unsu…' to match /error:\w+:PEM routines:\w+:no start line/ at /Users/samonela/code/node-samlp/test/samlp.tests.js:691:38 at Request._callback (test/samlp.tests.js:652:9) at self.callback (node_modules/request/request.js:185:22) at Request.emit (node:events:514:28) at Request.<anonymous> (node_modules/request/request.js:1154:10) at Request.emit (node:events:514:28) at IncomingMessage.<anonymous> (node_modules/request/request.js:1076:12) at Object.onceWrapper (node:events:628:28) at IncomingMessage.emit (node:events:526:35) at endReadableNT (node:internal/streams/readable:1408:12) at process.processTicksAndRejections (node:internal/process/task_queues:82:21) 2) samlp response signing signResponse=true and signAssertion=false when invalid signing key is used should return an error: Uncaught AssertionError: expected 'error:1E08010C:DECODER routines::unsu…' to match /error:\w+:PEM routines:\w+:no start line/ at /Users/samonela/code/node-samlp/test/samlp.tests.js:741:38 at Request._callback (test/samlp.tests.js:652:9) at self.callback (node_modules/request/request.js:185:22) at Request.emit (node:events:514:28) at Request.<anonymous> (node_modules/request/request.js:1154:10) at Request.emit (node:events:514:28) at IncomingMessage.<anonymous> (node_modules/request/request.js:1076:12) at Object.onceWrapper (node:events:628:28) at IncomingMessage.emit (node:events:526:35) at endReadableNT (node:internal/streams/readable:1408:12) at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
I checked on response.body
when it doesn't match as expected - both times it appears to be
error:1E08010C:DECODER routines::unsupported
Is there a setup step that needs to be completed first?
EDIT I noticed the .github/workflows/ci.yml file targets node-version: [12.x, 14.x, 15.x, 16.x]
so I was able to setup a dockerfile:
# specify the node base image with your desired version node:<version>
FROM node:16
Then with a mounting -v
of the local directory to /code
I can run cd code && npm run cover
. The tests pass before and after I made these changes to remove the dependency querystring. I'll attempt to add another test for more coverage.
from node-samlp.
Related Issues (20)
- update xml-crypto dependency HOT 3
- Update saml dependency HOT 1
- Current backwards compatability checks are preventing dependencies from being updated. HOT 2
- Math.random() is not cryptographically secure HOT 1
- Add Organization Details to samlp.metadata
- Request for help
- Dynamically Set Audience
- Uncaught Exception Error in samlp.logout
- Update xml-crypto dependency to solve npm audit issue 1769 HOT 1
- Found Vulnerability ' Improper Input Validation ' and ' Prototype Pollution ' on Synk.io HOT 3
- Npm audit advisories found HOT 1
- Function is not defined error HOT 1
- Request for upgrading the ejs package to the patched version 3.1.10
- Missing saml: prefix on Issuer and NameID tags in LogoutRequest HOT 1
- redirectEndpointPath documentation HOT 1
- 401 improvement HOT 1
- SAML assertion signing using HSM
- NPM Release for 3.4.2? HOT 1
- Can I get an example code
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-samlp.