Coder Social home page Coder Social logo

Comments (5)

Irrelon avatar Irrelon commented on July 2, 2024

Surely this is correct behaviour though? Since the scopes should be a logical OR not an AND.

from express-jwt-authz.

saulimus avatar saulimus commented on July 2, 2024

Then that should be documented and not implied.

from express-jwt-authz.

Irrelon avatar Irrelon commented on July 2, 2024

@saulimus Makes sense. Would you like to put in a PR for the updated doc?

from express-jwt-authz.

akehir avatar akehir commented on July 2, 2024

Actually, this library uses arrays of arrays of strings for the logical AND, and arrays of strings for a logical OR.

// Required: "read" OR "write"
app.use(guard.check([
  ['read'],
  ['write']
]))

// Required: "admin" OR ("read" AND "write")
app.use(guard.check([
  ['admin'],
  ['read', 'write']
]))

To me, it makes sense to have both options.

from express-jwt-authz.

akehir avatar akehir commented on July 2, 2024

Actually, I just realized, one can just verify multiple scopes like this:

// create retrieve endpoint endpoint
app.get('/endpoint', checkJwt, jwtAuthz(['READ']), jwtAuthz(['WRITE']), function (req, res) {
  // code that retrieves the user's balance and sends it back to the calling app

  res.status(201).send({message: "{\"message\": \"This is the GET /endpoint endpoint\""});
});

Therefore probably it's ok to leave the implementation as is, and update the documentation.

from express-jwt-authz.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.