Comments (9)
Can you share your session store?
I think it is easier for you to change it to return false in this case since it can break BC for users using this package already.
from auth0-php.
My session store class is a wrapper for the Phalcon Framework Session class. How would be best to share it?
I agree breaking BC would be bad. However the reason I flagged this as an issue is that if people are trying to use a generic session store with this package then flase is a valid value for something stored in the session and therefore a generic class will return null when a key is not present.
I suppose in my wrapper class I can change the return to be false if null seeing aas that wrapper is only being used with the Auth0 package.
from auth0-php.
Yes, make sense.
I am planing in releasing a new version (not sure if a new minor or mayor) with Guzzle 6.1 (latest).
I think I can push this change too since (not a big deal if it is a mayor).
How does it sounds?
from auth0-php.
Sounds fair enough! :)
! thing I might add though, if you are thinking of using a new version have you considered unirest (http://unirest.io/) instead of Guzzle?
from auth0-php.
never hear of it, will take a look but I doubt I will change it, I think I will just bump the guzzle version. Are you using it? why unirest over guzzle?
from auth0-php.
I find Guzzle to be very long winded and not very nice to work with. Unirest is much simpler and cleaner.
I use Guzzle in the project I am working with Auth0 on, but I am using unirest in a more recently started project and am finding that much more enjoyable.
from auth0-php.
ok, I will have it in mind. Based on how much it changed from guzzle 5 to 6, I will evaluate the change :)
from auth0-php.
It will be ready in v2.0
I will release it today (uses guzzle 6 sorry)
from auth0-php.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from auth0-php.
Related Issues (20)
- Recent changes break existing auth0/login configuration HOT 2
- Authentication#emailPasswordlessStart returns 400 (Bad Request) HOT 3
- Provided state breaks the flow with "Invalid state" error HOT 3
- Migrating from PHP SDK 7 to 8 - session not persisting HOT 4
- Error when i use $auth0->exchange in php
- Unable to retrieve Management API access token due to change in 8.4.0 HOT 3
- Browser Header Field Exceeds Limit HOT 4
- Laravel 10 install does not work - Error with composer HOT 3
- Breaking change in minor update HOT 2
- Error thrown when attempting to verify access token HOT 16
- Problem encountered with the $sdk->exchanges() method between versions 8.4.0 and 8.5.0 HOT 7
- Adding an explanation to the StateException regarding the possible reasons for the access token being missing. HOT 2
- Trigger deprecation and fallback to `none` strategy on configuration HOT 2
- use final-annotation instead of hard-final HOT 1
- JWT generator: wrong header key "type" HOT 1
- Cannot empty initiate_login_uri with API
- Double signature verification HOT 1
- ClientAssertionGenerator has a static expiry of 180 seconds. HOT 1
- Invalid state HOT 3
- HTML Entity Encoding of received cookies can lead to invalid state errors HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from auth0-php.