Address format? about bitsv

Great, no problem. Do you think you can make a new pip release soon?

I have the WalkingLiberty changes together but just wanted to have the address format standardized before using it.

[AustEcon]

That's awesome.

Yes. That sounds about right. It needs work in that department.

The intention is to change it all back to Legacy format to be same as everyone else on bsv network/apis etc but will probably have to bump to 0.7.0 because will break ppl's code.

So safest thing is to put in an a couple of lines that check address format and remedy the situation in case...

I also want to do a breaking change to my latest bip32 support stuff to choose better variable names and make it more intuitive to use. I just banged it out quickly because I was having requests for it...

I am guessing it should be able to send to both address formats as it is. For now do you think it would be safe to start returning 1.... format as default for .address?

[AustEcon]

Probably. Can't be sure though. Not at my PC. About to start the work day... but thinking on it... because all the functions derive from the Private_key class. If none of them rely on that attribute being in a particular format, should be sweet to change the return type to 1.... format. You never know though who out there might be depending on it remaining that way though?

I guess this is where the testing modules come in handy too. Can put out a clear summary of what parts change and what stays fully functional :)

I could understand someone wanting a bitcoinsv:q... format, but not bitcoincash:q... format. Personally, I think this should be fairly safe. If someone wants to be certain nothing will break, they should be pinning versions anyway.

I'll have a look at this and see. Most stuff that has cashaddr support supports both.

[AustEcon]

Thanks for the PR.
I put out a small message in _unwriter's slack... sounds like it should be fine / recommended to pretty rapidly remove the cashaddr format altogether...
I'm planning a big weekend of coding so expect a fair few commits this weekend Haha.

[AustEcon]

No problem. I'll likely be able to do it today.

[AustEcon]

@teran-mckinney I have just put out a new release 0.7.1

Great, thank you!

[AustEcon]

I just saw this on bottle... B://fd0a393807e8ba88c7c7470175ed7cecfbcdc111d827af013e9f351bb4548b49 Nice :) I have just started to sink my teeth into some of _unwriter's protocols now. Successfully uploaded an image following the b:// and c:// protocols just now.

…

On Sat, Apr 20, 2019 at 1:47 AM Teran McKinney ***@***.***> wrote: Great, thank you! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB57MSARPDHXHWKDJAMCVULPRHEP7ANCNFSM4HGWN2MA> .