Coder Social home page Coder Social logo

Comments (12)

harikt avatar harikt commented on May 21, 2024 1

Hi @elboletaire ,

I am closing this for I don't think we will be removing the class Di wiring test. But on another note, we may be pushing a 2.x or 3.x in the mean time. So hopefully everything will be good.

Hope that is ok with you.

Thank you

from aura.intl.

elboletaire avatar elboletaire commented on May 21, 2024

I've just tried a project that was working (and building) and currently crashes due to this issue. You can try it by yourself on this repo: https://github.com/elboletaire/less-cake-plugin

git clone the repo + composer install && phpunit .

from aura.intl.

elboletaire avatar elboletaire commented on May 21, 2024

This is really weird because you have not made any changes to your code since April and 30 days ago I successfully ran a build.

from aura.intl.

elboletaire avatar elboletaire commented on May 21, 2024

Given the less-cake-plugin repo I've been able to fix the issue manually-requiring the aura/framework package. But if I do so with the other plugin (the one which originated this issue) then other things break, and that are really weird because the files that cannot find now really exist:

PHP Fatal error:  Class 'Aura\Filter\Rule\MockValue' not found in /home/elboletaire/www/projectes/metropolitan/web-2015/vendor/cms/files/vendor/aura/filter/tests/Aura/Filter/Rule/MethodTest.php on line 38

Fatal error: Class 'Aura\Filter\Rule\MockValue' not found in /home/elboletaire/www/projectes/metropolitan/web-2015/vendor/cms/files/vendor/aura/filter/tests/Aura/Filter/Rule/MethodTest.php on line 38

This makes me think that I'm doing something wrong, but don't know what. Any help would be appreciated.. 😓

Edit (well, I've not edited, I'm writing while investigating): I'm checking others' plugins and I'm having exactly the same issue...

https://github.com/FriendsOfCake/bootstrap-ui
https://github.com/FriendsOfCake/search
https://github.com/FriendsOfCake/crud

I've tried it in other computers and other different PHP versions and have the same issue everywhere.

from aura.intl.

harikt avatar harikt commented on May 21, 2024

@elboletaire wiring test is only for testing with the framework ( v1 ) . It can be removed for v1 is no longer supported . You can also mark skip or ignore it to run the phpunit . I wonder why the vendors are running unit test though.

Hope that helps!

Thanks.

from aura.intl.

elboletaire avatar elboletaire commented on May 21, 2024

So, the problem is with CakePHP which is loading the test files, right?

from aura.intl.

harikt avatar harikt commented on May 21, 2024

@elboletaire what I was telling was your tests may not need to run the aura/intl tests. I am not sure whether it was cake running all tests for the 3rd party packages.

Probably you can send a PR removing the wiring tests and see what @pmjones think about the removal.

from aura.intl.

elboletaire avatar elboletaire commented on May 21, 2024

My tests are not running the aura/intl tests.. if they are running is because CakePHP core is running them. That's why I said that "the problem is with CakePHP".

What I would like to know is where should I open a new issue if it is not your fault... but as I can see, in your tests you load a file which is not included (nor in the code files, nor in composer dependencies), so the problem here is with aura/intl.

Am I right?

from aura.intl.

harikt avatar harikt commented on May 21, 2024

@elboletaire I have send a PR with what I think to resolve the issue. Hope that helps. See #18 .

from aura.intl.

elboletaire avatar elboletaire commented on May 21, 2024

I'm not sure if this will fix my issue but at least we fixed something! 😄

from aura.intl.

elboletaire avatar elboletaire commented on May 21, 2024

Finally my problem was running phpunit . (with that trailing dot) which runs tests recursively from current path 😅 .

Anyway it served to fix the issue with your tests 😄

from aura.intl.

harikt avatar harikt commented on May 21, 2024

Just for reference we have released 3.0.0-beta1 : https://github.com/auraphp/Aura.Intl/releases/tag/3.0.0-beta1 . Supports 5.6+ ( PHP 5.6 ends support today ) . ie one reason 5.5 was not added.

from aura.intl.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.