Coder Social home page Coder Social logo

Cells should be immutable about aurae HOT 3 CLOSED

krisnova avatar krisnova commented on August 16, 2024
Cells should be immutable

from aurae.

Comments (3)

future-highway avatar future-highway commented on August 16, 2024

Reviewing the code as it is now, we are almost there. I think we can make this possible in 2 steps:

  1. Create a 3rd variant on CellState called Freed that change the fn free to set that state instead of going back to Unallocated (this prevents Cell.allocate from doing anything in Freed also.
  2. We also want to make sure that we don't accidentally make any of Cell's fields public. We can do this 2 ways:
    a. Write a comment and hope it gets paid attention too
    b. Obviously a macro that will override any attempt to set pub or pub(crate) (there may be a crate for this if we want this choice, or it shouldn't be hard to write)

from aurae.

future-highway avatar future-highway commented on August 16, 2024

#180 implements step 1 and step 2a.

from aurae.

dmah42 avatar dmah42 commented on August 16, 2024

i'm happy with this until we find out it was insufficient and the comment ended up being a sign not a cop.

from aurae.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.