reserved identifier violation about aubio

[piem]

hi @elfring

ok, i believe this would match all the clashing macro names:

$ git ls | xargs egrep "#(define|ifndef|endif.*) _"

while preserving the ones aimed at the pre-processor:

$ git ls | xargs egrep "#ifdef _"

Now, what about file scope objects such as struct _aubio_resampler_t { ... } ?

[elfring]

Did your software fiddle with the reserved name space in inappropriate ways only for a few include guards?

[piem]

yes, there are have a few more clashes:

• All identifiers that begin with an underscore (1999 C)
• Each name that contains a double underscore (2003 C++)
• Names that end with _t (POSIX)

See also GNU libc's reserved names.

[piem]

After @6f42c16, we are know at:

• All identifiers that begin with an underscore (1999 C)
• Each name that contains a double underscore (2003 C++)
• Names that end with _t (POSIX)

No plans to fix the latest for now. Hopefully we won't clash with a future POSIX! :)

See also this discussion.

[elfring]

Thanks for your improvement of affected include guards.