MAC list broken with proper handling of set mac-vlan callback about vfd

[pcarver]

Is there a strong reason to use the implicit logic of "first element in the array is special" vs having an explicit field to define the default MAC in addition to an array of equally non-special additional MACs?

[ScottDaniels]

One less field to document, one less field for someone to forget to change. If you feel strongly about having a specific default field, then I'd suggest this change to the overall json (quotes omitted for simplicity):

macs: {
default: 04:30:86:11:04:17,
whilte_list [ m1, m2, ... mn ]
}

We'd have to support the old style for a while for backward compatibility.

[pcarver]

I would say that the "specialness" of the first element in the array ought to be documented, so doesn't save much documentation to document a separate field. The JSON you proposed looks exactly how I think it ought to look. I would suggest that a default or sample config file should include comment lines that indicate that if default MAC is missing it will be generated randomly (if you still want to support the random MAC generation you mentioned) and that if white_list is present that it will cause "set mac-vlan" callbacks to be ignored.

[ScottDaniels]

Agree; the use of the first address as the default is already documented and is the current behaviour, as is the generation of the random address if the array is missing. Regardless doc changes are needed.