[Suggestion] - internalProxies line should be removed when there is no proxyInternalIps value in tomcatConfig about data-center-helm-charts

[bianchi2]

@SuperWonjune PRs in docker repos:

• https://bitbucket.org/atlassian-docker/docker-atlassian-jira/pull-requests/137
• https://bitbucket.org/atlassian-docker/docker-atlassian-confluence-server/pull-requests/162
  and docs PR #797

[bianchi2]

@SuperWonjune I'll raise PRs to both. Thanks for bringing this up!

[SuperWonjune]

More question : It appears that the RemoteIpValve value configuration is only in Confluence value.yaml, Is there any specific reason for not applying same option to Jira or any other products?

[bianchi2]

@SuperWonjune good questions!

In fact, server.xml is generated in the image entrypoint https://bitbucket.org/atlassian-docker/docker-atlassian-confluence-server/src/master/config/server.xml.j2. Template in the Helm chart is only necessary if you run as non root (in which case the non root user has no permissions to write to server.xml).

Yes, you are right, no x-forwarded-for headers will be added if internalProxies is empty, and having defaults can certainly help match commonly used interfaces (say, in AWS).

As to why only Confluence has remoteValve and Jira does not have it, I don't have an immediate answer. Config files (or rather templates) used in images (and here in Helm) are copies of config files distributed by products.

[bianchi2]

@SuperWonjune and feel free to raise a PR with the suggested change!

[SuperWonjune]

Thank you for your response.

It seems more appropriate to create an Issue and submit a Pull Request on the Bitbucket Repository you shared. (Though it doesn't seem like granting permissions to regular users)

I think we can close this issue.

[SuperWonjune]

Hello @bianchi2 I hope you've been well.

I'm reaching out regarding the progress on the request I made last time. Currently, in the server.xml template file of Confluence, the internalProxies setting allows for proper configuration of the client IP. However, in Jira server.xml file used in image, there is no related code like <Valve className="org.apache.catalina.valves.RemoteIpValve" in the template file. This means that in Jira, in a Proxy environment, the Client IP still cannot be correctly output.

Could you please share the progress on the PR for the server.xml.j2 file in the official Jira image below:

Jira: https://bitbucket.org/atlassian-docker/docker-atlassian-jira/src/master/config/server.xml.j2
Confluence: https://bitbucket.org/atlassian-docker/docker-atlassian-confluence-server/src/master/config/server.xml.j2

[bianchi2]

@SuperWonjune this has been fixed in helm charts (if you prefer Helm to generate server.xml) but not in jinja templates in the images themselves. This will be fixed.

[SuperWonjune]

@bianchi2
Thanks for sharing the progress.
Is there any open issue ticket or ongoing PR that we can check?