Comments (12)
So I guess, we will have
asyncapi diff <file1> <file2l>
for file.
yup, but with clear indication which one is checked against the other, I mean if file1 is checked against file 2? or the opposite
the part about file
flag I mentioned (that it will be removed) is something that @Souvikns will work on #37 (comment)
from cli.
Yeah sure, let me know if you need anything.
from cli.
hmm, it doesn't.
Lukasz said that this functionality should be a separate implementation independent of the command.
Yeah, you should create a wrapper around diff and connect it with CLI. For a little context, the CLI is this, so you just need to create a function wrapping your diff
library and create a new command for it.
Can you give me some context on what kind of output diff is generating? As of now, all output is printed in the console itself.
from cli.
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
from cli.
Hey, there is a topics covered here that are important no matter if we work on diff or not: the output
atm, library outputs on terminal only. There is no --output
option so far. This is independent from diff
as we need output to file functionality in many different commands, for relations finding or for optimizations. This needs to be implemented separately
regarding optional flags, we so far tend to always have name, so instead of --json
do --format=json
as if it comes to asyncapi diff --files <file1.yml> <file2.yml>
, we have some discussions in other issue that are kind of going the direction of getting rid of --file
or --files
flag, as flags are options, they are optional, while in case of file, it is must have, not optional, it is kinda a center of all the things
from cli.
atm, library outputs on terminal only. There is no --output option so far. This is independent from diff as we need output to file functionality in many different commands, for relations finding or for optimizations. This needs to be implemented separately
Got it.
regarding optional flags, we so far tend to always have name, so instead of --json do --format=json
👍
as if it comes to asyncapi diff --files <file1.yml> <file2.yml>, we have some discussions in other issue that are kind of going the direction of getting rid of --file or --files flag, as flags are options, they are optional, while in case of file, it is must have, not optional, it is kinda a center of all the things
So I guess, we will have
asyncapi diff <file1> <file2l>
for file.
from cli.
Now that the migration to Oclif is done, I will start working on this. Hope to make a PR by the end of this week.
from cli.
@Souvikns Does the CLI have the ability to output data into files? Since, Lukasz said that this functionality should be a separate implementation independent of the command.
from cli.
Can you give me some context on what kind of output diff is generating? As of now, all output is printed in the console itself.
Right now I'm just generating the default json output.
from cli.
Solution that we should consider for that issue asyncapi/community#249 It's only an idea so please treat it as suggestion, not final approach. Feel free to comment :)
from cli.
This issue has been automatically marked as stale because it has not had recent activity 😴
It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.
There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.
Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.
Thank you for your patience ❤️
from cli.
Should we close this issue now that we have integrated diff in CLI?
from cli.
Related Issues (20)
- Migrate to @oclif/core V3
- [CLI] Add 'source' metadata for metrics collected HOT 2
- Add parser middleware to /generate
- Deploy API to production
- Cleanup codeowners HOT 2
- Add Time to First API Design DX metric HOT 4
- [BUG] Missing on-workflow-trigger for update-docs-in-website action HOT 6
- [BUG] The bundle command does not bundle referenced files HOT 22
- [BUG] Release pipeline is blocked by the windows cache issue HOT 3
- [CLI] Add metadata for metrics collection in remaining commands
- [FEATURE] add optional flag `rawPropertyNames` to TypeScriptFileGenerator HOT 1
- [FEATURE] Automatic Version Update Notification HOT 3
- Improve `fromTemplate.test.ts` to avoid intermittent error on CI HOT 5
- Implement new UI/UX improvements in new command HOT 1
- Implement new UI/UX improvements in config command
- Implement new UI/UX improvements in convert command HOT 1
- Implement new UI/UX improvements in generate command HOT 1
- Implement new UI/UX improvements in optimize command HOT 3
- Implement new UI/UX improvements in start command HOT 11
- Implement new UI/UX improvements in validate command HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.