Coder Social home page Coder Social logo

Comments (18)

derberg avatar derberg commented on July 28, 2024 4

how about (especially looking at the PR mentioned above by @fmvilas that relates to @arjungarg07 work):

asyncapi generate diagram --type='plantuml'
asyncapi generate docs --type='html'
asyncapi generate types --language='typescript'
asyncapi generate app --type='nodejs'

thoughts? who cares about the dependencies, in which command what tool is used, cupid or modelina?

we would only need to leave the gate open for folks with custom templates 🤔

asyncapi generate fromTemplate --template='@asyncapi/java-spring-template'

from cli.

jonaslagoni avatar jonaslagoni commented on July 28, 2024 1

Without knowing any depth of the implementation from a CLI side of things, I assumed you would use the context?

Or would it need to use something like asyncapi generate models --file=./myfile.yaml --language=ts? 🤔

from cli.

peter-rr avatar peter-rr commented on July 28, 2024 1

Alright, you can ignore my previous comment then :)

from cli.

github-actions avatar github-actions commented on July 28, 2024

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

from cli.

boyney123 avatar boyney123 commented on July 28, 2024

@jonaslagoni like the idea!

How will it know which file to use?

from cli.

jonaslagoni avatar jonaslagoni commented on July 28, 2024

Also, one point to consider, since Modelina, don't only support AsyncAPI documents as inputs, I guess through the CLI it should be possible to provide other input types as well, or?🤔

from cli.

boyney123 avatar boyney123 commented on July 28, 2024

Also, one point to consider, since Modelina, don't only support AsyncAPI documents as inputs, I guess through the CLI it should be possible to provide other input types as well, or?

I'm not sure, where do the boundaries start and stop. Given it's the asyncapi cli, I think it should just handle the related inputs personally (asyncapi files) or at least to start?

from cli.

jonaslagoni avatar jonaslagoni commented on July 28, 2024

I'm not sure, where do the boundaries start and stop. Given it's the asyncapi cli, I think it should just handle the related inputs personally (asyncapi files) or at least to start?

Yea, I agree. Lets just focus on AsyncAPI files and see where it goes 👍

from cli.

derberg avatar derberg commented on July 28, 2024

are you sure about models here asyncapi generate models? what about generator itself, how would it be called? asyncapi generate template? -> I'm afraid user experience depends on how underlying libraries are structured

shouldn't it be asyncapi generate filepath/contextname model/template --parameters/--options ?

from cli.

jonaslagoni avatar jonaslagoni commented on July 28, 2024

shouldn't it be asyncapi generate filepath/contextname model/template --parameters/--options ?

Can you elaborate on how you see the difference between the generator and Modelina?

Do you mean in terms of generation we could do this:
Generator: asyncapi generate filepath/contextname @asyncapi/template --parameters="something"
Modelina: asyncapi generate filepath/contextname model --language=typescript

from cli.

derberg avatar derberg commented on July 28, 2024

except of @asyncapi/template is just confusing 🤔 as it is not a command :( it is an argument that might be different depending on what template you want to use. Also template cannot be a flag as options should not be mandatory 🤔

Have a look at #143 and another use case for asyncapi generate

from cli.

jonaslagoni avatar jonaslagoni commented on July 28, 2024

I think that makes sense! Even if we change it later it should not be a problem, we just need to start with something that makes sense 😄

from cli.

magicmatatjahu avatar magicmatatjahu commented on July 28, 2024

Solution that we should consider for that issue asyncapi/community#249 It's only an idea so please treat it as suggestion, not final approach. Feel free to comment :)

from cli.

fmvilas avatar fmvilas commented on July 28, 2024

I'm happy to be a mentor for this issue in the Mentorship program.

from cli.

peter-rr avatar peter-rr commented on July 28, 2024

@fmvilas I'm also interested to contribute to this issue for the Mentorship program, but I'm not sure whether I can opt for different issues or not 🤔 In case it's only possible to opt for just one issue, I wouldn't mind to pick one or the other depending on the priority or importance of the issue for AsyncAPI, I can adapt to it :)

(The other issue I'm talking about is #184)

from cli.

jonaslagoni avatar jonaslagoni commented on July 28, 2024

@fmvilas any reason this was added with gsoc 😄? As there already is a PR that adds it and we are currently stuck based on the feedback with no way to really move forward 🤷

#173

from cli.

fmvilas avatar fmvilas commented on July 28, 2024

Oh sorry, I haven't seen it. Removing the label then.

from cli.

asyncapi-bot avatar asyncapi-bot commented on July 28, 2024

🎉 This issue has been resolved in version 0.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

from cli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.