Coder Social home page Coder Social logo

Comments (8)

sunli829 avatar sunli829 commented on April 28, 2024

Thank you for your advice, that's a great idea, and I really need your help. These days I want to optimize the code in the subscription to make it easier to use, so our work doesn't conflict.If you have time, you can help implement `ErrorExtensions'.😁
Thanks again!

from async-graphql.

nicolaiunrein avatar nicolaiunrein commented on April 28, 2024

I thought a little about it and started implementing a first draft. Will be ready for review tomorrow or on monday I think.

from async-graphql.

sunli829 avatar sunli829 commented on April 28, 2024

Is a wrapper similar to PositionError?

from async-graphql.

nicolaiunrein avatar nicolaiunrein commented on April 28, 2024

Is a wrapper similar to PositionError?

Yes exactly. See PR for details.

from async-graphql.

sunli829 avatar sunli829 commented on April 28, 2024

I reimplemented the error type in branch error-type, the error extension is still not very good, give some advice?

from async-graphql.

nicolaiunrein avatar nicolaiunrein commented on April 28, 2024

I looked at the error-type and made some adjustments. Please have a look and also at the example uses cases. It turns out to be quite tricky to implement some sort of default implementation but still let the user implement custom behaviour. Feel free to undo the commit if you don't like it.

from async-graphql.

nicolaiunrein avatar nicolaiunrein commented on April 28, 2024

I also replaced the trait bound std::err::Error with std::fmt::Display because I think Error is an unnecessary restriction.

from async-graphql.

sunli829 avatar sunli829 commented on April 28, 2024

Thank you, It's merged to master.😁

from async-graphql.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.