DataSource macro hides errors about async-graphql

[phated]

If you use #[DataSource] and make a type error inside https://github.com/phated/twentyfive-stars/blob/master/server/src/data/card.rs#L38, you will see the error not display properly.

[sunli829]

Yes, it only adds # [async_trait::async_trait], I think if rust stable version supports async trait, we do not have to change the code. 😂

[phated]

@sunli829 maybe the problem exists because the version async-graphql uses it 0.1.24, but the current version is 0.1.30

[phated]

Would you accept removing the macro and documenting that async_trait must be used with DataSource?

[sunli829]

I want to keep it for expansion, maybe one day we want to add something? 😂

[phated]

Ok, maybe we need to upgrade the dependency for now.

[sunli829]

While using the #[DataSource] macro, any errors inside the implementation of the trait are marked on the trait itself (and in some weird cases, hoisted to line 1 of main).

Normally, the error message is not hidden. Can you give an example to reproduce the problem?

[sunli829]

Thanks, I will track this issue. 😁

[sunli829]

I still haven't figured out why this problem was caused, but I solved it in a way that seemed silly together. 😂