Comments (2)
We should have a similar interface (which the functions have), but not the same as they do need different input parameters.
Can you clarify what you mean by "similar, but not the same"? I think you mean, "as similar as possible, but some functions will need different keywords"?
I believe that we should give the functions more meaningful names and make them none-private.
My plan was to make a public function for each model:
extinction_ccm89()
extinction_od94()
[etc]
The different ccm89-like coefficients should also not be stored in the functions itself (IMHO)
Currently they are in module-level variables, not in the functions themselves. See lines 307-314. (unless I'm mistaken what you mean here?)
from specutils.
taken care of by #55
from specutils.
Related Issues (20)
- Spectrum1D.__str__ formatting error
- DOC: Broken link to old mailing list needs to be fixed HOT 4
- Better document/test user-made GWCS input
- Specutils in the muler and gollum ecosystem and prospect for upstreaming HOT 3
- TST: Ensure numpy dev is actually installed in devdeps
- TST: Python 3.12
- Spectrum1d.read suddenly won't read JWST x1d data automatically. HOT 1
- Serialization of Spectrum1D object (How to make Spectrum1D pickle-able?)
- Can spectrum object be lazy?
- TST: oldest deps job failed because something is forcing numpy upgrade to 1.24
- BUG: version number is off for `stable` on RTD HOT 1
- Why are SDSS spPlate readers "hidden" in the sdss.py loader? HOT 1
- Round tripping read/write does not preserve WCS HOT 5
- Improve/Update Developer docs HOT 5
- Add spPlate test HOT 1
- Improve documentation about headers
- Inconsistant expectation for location of header data (vs. other metadata) HOT 2
- Create a reader for DESI data files HOT 2
- Spectrum1D WCS has wrong number of dimensions as an NDCube HOT 1
- SpectralCoord can't handle pixel units
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from specutils.