Coder Social home page Coder Social logo

Comments (2)

kbarbary avatar kbarbary commented on August 15, 2024

We should have a similar interface (which the functions have), but not the same as they do need different input parameters.

Can you clarify what you mean by "similar, but not the same"? I think you mean, "as similar as possible, but some functions will need different keywords"?

I believe that we should give the functions more meaningful names and make them none-private.

My plan was to make a public function for each model:

extinction_ccm89()
extinction_od94()
[etc]

The different ccm89-like coefficients should also not be stored in the functions itself (IMHO)

Currently they are in module-level variables, not in the functions themselves. See lines 307-314. (unless I'm mistaken what you mean here?)

from specutils.

wkerzendorf avatar wkerzendorf commented on August 15, 2024

taken care of by #55

from specutils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.