Coder Social home page Coder Social logo

io.votable warnings about astroquery HOT 6 CLOSED

astropy avatar astropy commented on July 19, 2024
io.votable warnings

from astroquery.

Comments (6)

astrofrog avatar astrofrog commented on July 19, 2024

Given that no services provide standard compliant tables (cc @mdboom) I think your first option is a likely hypothesis ;-) Can we ask the SIMBAD people to fix the tables?

from astroquery.

mdboom avatar mdboom commented on July 19, 2024

W46 is the most worrisome as it implies loss of data, but all of them appear to be legitimate.

from astroquery.

keflavich avatar keflavich commented on July 19, 2024

We'll need to clean up all these warnings by the first release... but if they're upstream issues, I'm not sure how to deal with them. @cdeil, this might be a good thing to work on.

from astroquery.

mdboom avatar mdboom commented on July 19, 2024

I would recommend this:

  1. Report all of the warnings upstream to the tool that created them. Reference this page which describes what the various warnings mean and often point back to the relevant part of the spec.

  2. If querying a particular server, in this case SIMBAD, always returns malformed data, you can temporarily turn off warnings when parsing the results. The catch_warnings context function in the stdlib is helpful for this. I would explicitly blacklist specific warnings, so that any we don't expect from SIMBAD won't creep through. And I'd put a note next to this to remove it in the future when upstream fixes their data.

  3. I would recommend never hiding W47 or W46, since they do imply a loss of data, and the user should know that their fields have been truncated.

Background: I take a hard line on standard conformity when it comes to VOTable. That seems to be the point, right? If everyone produces data that requires special hacks and workarounds in the reader, it doesn't really make data exchange any easier, right?

from astroquery.

keflavich avatar keflavich commented on July 19, 2024

@mbdoom- thanks for the summary & suggestions. I agree that a standard only makes sense if enforced. I just didn't want the responsibility of enforcement =)

What we may do, though, is try to slim down the warnings to one big angry warning that "Data is truncated - see self.votable_warnings for details" if the missing data warnings persist and are too verbose.

from astroquery.

keflavich avatar keflavich commented on July 19, 2024

All votable warnings are suppressed by default. As we've found out over the past few months (and others have known for a long time), there are very few fully compliant VOTables out there:
http://stsdas.stsci.edu/astrolib/vo_compliance_tests/
So we'll continue suppressing & reporting upstream as we go.

from astroquery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.