Comments (5)
We do use the ProgressBar from astropy at a few places (the main difference is that it handles parallel downloads), so adding a progress bar to ESO is totally fine.
Also, tdqm is quite a small additional dependency, so I would be on board of adding it if you rather use it directly than ProgressBar
.
cc @keflavich
from astroquery.
I wasn't aware of the astropy implementation of ProgressBar. Do you know how it differs from tqdm? Does the astropy implementation work for jupyter notebooks? I'm not hell bend on using tqdm, I just use it because of how easy it is to use, so open to input. I agree that tqdm is not a huge dependency, but I guess we can avoid it if there is precedence in using native astropy for the same functionality.
from astroquery.
I think tqdm is more widely used and more flexible; I'd be happy to switch to it. But functionally, they're the same, and we can just make the progressbar type be specifiable by the user & default to astropy
https://docs.astropy.org/en/stable/api/astropy.utils.console.ProgressBar.html
from astroquery.
Honestly, I don't know how nicely it works in notebooks or on log files, etc as I'm not using it at a user level.
Do would just reiterate, feel free to choose whichever works better for the module, if it's tqdm then we're happy to add it as a dependency.
(I really don't know what will happen to the astropy version, if it will stay there long term or will be deprecated or maybe just refactored to also use tdqm)
from astroquery.
tqdm works in both with from tqdm.auto import tqdm
. I think the astropy version requires you to tell it what environment you're in.
from astroquery.
Related Issues (20)
- SDSS DR18 implementation HOT 7
- Cannot change Vizier configuration value neither at runtime nor with config file HOT 8
- Astroquery.mpc proper_motion issues numpy.core._exceptions._UFuncNoLoopError: ufunc 'multiply' HOT 2
- Simbad Query returns wrong (?) error values HOT 3
- BUG DOC: module docs in solarsystem is broken for some modules
- Astroquery.mpc i = text_table.index('\n', text_table.index('h m s')) + 1 ValueError: substring not found HOT 1
- Switch to dict instead of ordered dict in Vizier find_catalogs HOT 3
- Splatalogue.query_lines() seems to be broken? HOT 2
- Slow Simbad.query_objects & IRSA.query_region searches HOT 6
- Use plot directive to generate figures
- modulate verbosity of astroquery.mast.Observations.download_products() HOT 1
- Add support for upload tables for queries in ALMA
- BUG: CI -- no space left on device HOT 2
- ESA Herschel download_data connection error HOT 2
- MAINT: retire/rename exceptions.TimeoutError in favour of requests
- TST: esasky tests take too long time and donwload too much data HOT 8
- BUG: alma test downloads 850+Mb of data HOT 8
- How to download Level 1 ancillary (*cbcd.fits and *cbunc.fits) from IRSA?
- Vizier.query_region() returns incorrect index for some catalog HOT 3
- CI: rerun failing tests at the end
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from astroquery.