Comments (7)
I think pyvo 1.5 is still premature to require package wide, but we can certainly bump the version a bit and also require more recent version for alma.
from astroquery.
Sure, if this is your strategy, although I don't see the clear benefit. Remind me please, is this just to accommodate users that pin their already installed pyvo
version?
from astroquery.
yes, this is to accommodate any users who are 1) cannot update for any reasons and 2) are not users of alma where features from a more recent pyvo is required (or irsa, as we do require 1.5 there, too)
I'm not sure how many are in this cross-section, but generally we don't require dependencies that are only a few months old.
from astroquery.
OK, so I wasn't really on board with this, but now that we finally bumped support for python 3.7 and 3.8, I don't see anything else that the most recent pyvo would auto-upgrade.
So, while it's a bit orthodox, I don't see any reasons for holding back this requirement change (and in fact this would fix some of the SIA2 related issues users starting to to report when using some of the astroquery modules with an old pyvo version).
@keflavich - are you on board for requiring pyvo>=1.5?
from astroquery.
Yes. My only concern is when installing into very old environments (CASA always packages with many years old python versions), I still want astroquery to function. But if this is solving real problems, sure, let's go ahead.
from astroquery.
We already dropped the python versions here.
Could you maybe double check if python 3.9 is generally ok with them? We can dial it back to 3.8 if absolutely necessary, but keep supporting 3.7 was already became problematic
from astroquery.
Let's not worry about supporting older versions. If astroquery happens to work when installed in those environments, great! But I don't want that to burden us or our CI.
from astroquery.
Related Issues (20)
- Add support for upload tables for queries in ALMA
- BUG: CI -- no space left on device HOT 2
- ESA Herschel download_data connection error HOT 2
- MAINT: retire/rename exceptions.TimeoutError in favour of requests
- TST: esasky tests take too long time and donwload too much data HOT 8
- BUG: alma test downloads 850+Mb of data HOT 8
- How to download Level 1 ancillary (*cbcd.fits and *cbunc.fits) from IRSA?
- Vizier.query_region() returns incorrect index for some catalog HOT 3
- CI: rerun failing tests at the end
- Bug in rows limitation in module vizier HOT 2
- Unexpected behavior when passing `obj_names` to `SDSS.query_region()`
- Handling No astronomical object found response HOT 5
- IRSA: adding SSA method HOT 1
- Astroquery.gaia API Error: RA cannot be converted to hour or hourangle. HOT 2
- MAST cloud dataset doesn't show level 3 data products
- SimbadClass got an unexpected keyword argument HOT 5
- API cleanup to make it more self consistent
- API discussion for `list_collections` HOT 4
- Astrometry.net: can query for job id once, rather than each time HOT 2
- BUG: vo_conesearch server SSL cert needs fixing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from astroquery.