Coder Social home page Coder Social logo

Comments (6)

jespinosaar avatar jespinosaar commented on July 3, 2024 2

Thanks for raising this issue @ManonMarchand , @stargaser and @bsipocz . We will check what is happening and let you know about the solution.

from astroquery.

stargaser avatar stargaser commented on July 3, 2024 1

From trying different astroquery pre-releases, I have found that astroquery==0.4.7dev8479 (Feb 6, 2023) works. From astroquery==0.4.7dev8792 (Jun 29, 2023) onwards, it fails.

from astroquery.

cosmoJFH avatar cosmoJFH commented on July 3, 2024 1

Hi @ManonMarchand, I've checked that the class astroquery/utils/tap/conn/tapconn.py was changed at the commit

Tsar Bomba Nick 18/3/23 1:15 Refactor: Made kwargs keyword only for astroquery/utils/tap/tapconn.py
rev number: e724f62

The method was changed from

def execute_tappost(self, subcontext, data,
                    content_type=CONTENT_TYPE_POST_DEFAULT,
                    content_type=CONTENT_TYPE_POST_DEFAULT, 
                    verbose=False):

to

def execute_tappost(self, subcontext, data,
                    content_type=CONTENT_TYPE_POST_DEFAULT,
                    content_type=CONTENT_TYPE_POST_DEFAULT, *,
                    verbose=False):

So the parameter verbose is now a keyword argument.

I have checked that if the method __launchJobMultipart in astroquery/utils/tap/core.py is changed to

    response = self.__connHandler.execute_tappost(context,
                                                  body,
                                                  contentType,
                                                  verbose=verbose)

the issue is not reproduced

from astroquery.

cosmoJFH avatar cosmoJFH commented on July 3, 2024 1

New PR #2892

from astroquery.

bsipocz avatar bsipocz commented on July 3, 2024

cc @esdc-esac-esa-int

from astroquery.

bsipocz avatar bsipocz commented on July 3, 2024

@cosmoJFH - thanks for the investigation, and sorry for not spotting this in #2690.

Will you open an PR with the fix or shall I?

from astroquery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.