Coder Social home page Coder Social logo

Comments (7)

denimalpaca avatar denimalpaca commented on July 24, 2024

I'm happy to open a PR here and add it, but I don't have access to an Athena instance to run tests against (could only do local tests, which are only so helpful). I can open that PR today and if you want to do live tests against it, that would help me a lot in getting this added ASAP.

from airflow-provider-great-expectations.

diman82 avatar diman82 commented on July 24, 2024

Hey @denimalpaca.
Sure, I can help with testing!

from airflow-provider-great-expectations.

denimalpaca avatar denimalpaca commented on July 24, 2024

@diman82 please see the PR linked!

from airflow-provider-great-expectations.

lionsdwarf avatar lionsdwarf commented on July 24, 2024

There is even a TODO comment in operator code for adding support for Athena connection. Can you please add support for this?

Here's the permalink instead

from airflow-provider-great-expectations.

denimalpaca avatar denimalpaca commented on July 24, 2024

Hey @lionsdwarf , PR #91 is open with this addition. I don't have access to Athena and can't test, however, so I'm just waiting for @diman82 or someone else to test the fix before I do a merge and release. If you'd like to help, we can close this issue out this week!

from airflow-provider-great-expectations.

lionsdwarf avatar lionsdwarf commented on July 24, 2024

We are interested in Trino support, which is also mentioned in the TODO comment.

I was curious if the recent upgrade to the core gx library to use database connection strings (instead of config parameters) would solve this problem, but it looks to me like the provider is already using the latest core version.

from airflow-provider-great-expectations.

denimalpaca avatar denimalpaca commented on July 24, 2024

Could you please open a separate issue for Trino support? I can look into opening another PR, but as I don't have access to Trino either, I'd need someone else to test it before I merge.

This and the Athena support is only for the default datasource being built; you can still use this operator with Trino now if you are supplying a checkpoint and have your datasources configured in the data context config.

from airflow-provider-great-expectations.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.