Coder Social home page Coder Social logo

Comments (6)

xntrik avatar xntrik commented on June 16, 2024

Good idea!

from devise_google_authenticator.

aligo avatar aligo commented on June 16, 2024

I have be using it with devise 3.x a while, the only problem is these to monkey-patchs(https://github.com/AsteriskLabs/devise_google_authenticator/blob/master/lib/devise_google_authenticatable/patches/display_qr.rb) don't support sanitized params. so i just rewrite these two controller to passby.

I think use devise after_inactive_sign_up_path_for this sort of api is better.

from devise_google_authenticator.

xntrik avatar xntrik commented on June 16, 2024

Hey @wedtm / @aligo - I'm certainly keen to help refactor some of the code, as I know there's likely to be a number of better ways to handle this.

I also need to apologise for the delay in getting to this, there's certainly a bit of work that this gem requires to properly support Rails 4 (and more gracefully handle the previous versions too). I'm travelling a bit until next week, so won't get an opportunity to check this out until then.

Although, I'm very open to all and everyone's suggestions!

from devise_google_authenticator.

shaneog avatar shaneog commented on June 16, 2024

Any update to this?

from devise_google_authenticator.

xntrik avatar xntrik commented on June 16, 2024

Sorry @shaneog - I've just tested with Rails 4.0.4, I believe this has worked since v0.3.7

from devise_google_authenticator.

xntrik avatar xntrik commented on June 16, 2024

Closing for the moment, but, feel free to re-open if some issues persist.

from devise_google_authenticator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.