DefaultLanguageName is getting set to 'null' about aspnetboilerplate

[worthy7]

Here is a timeline showing where the sql to update the settings table is executed. The red line showing where the Logs.txt file shows a timestamp while executing "GetAll"

And this is the log file where I believe something is updating the setting for the user to 'null'

[worthy7]

Related issue from the past #5399

[worthy7]

I also think that this code should be checking the language is actually an allowed language from the list of AbpLanguages. If not, it can just assign any language to the user which may not be a supported language and instead should revert to the default.

Or, this code for setting the language, should just not exist at all.

[worthy7]

I can recreate this bug now in a solid test case.

1. For any user, switch to the default app language (so the AppSettings table will have no entry for their language).
2. Go into incognito mode, sign in with that user.

Due to the above mentioned, it will create a 'null' entry in the AppSettings table.

[worthy7]

Hi @ismcagdas

Regarding this: https://aspnetboilerplate.com/Pages/Documents/Localization#asp-net-core

AbpUserRequestCultureProvider (ABP's provider): If the user is known via IAbpSession and has explicitly selected a language before (and saved to ISettingManager), then use the user's preferred language. If the user is known but has not selected any language and the .AspNetCore.Culture cookie or header has a value, set the user's language setting with that information and use this value as the current language. If the user is unknown, this provider does nothing.

How does the system know if the user explicitly selected the application default language?

[ismcagdas]

saved to ISettingManager

It must be saved to AbpSettings table.

[worthy7]

How is that possible though? The system does not save it to the table if it is the same as the default app language.

[ismcagdas]

When you get a setting value using setting manager, the default value is returned if there is no specific setting saved for that user.

[worthy7]

Right, but if you try to set the language setting of a user to that of the app default, it does not go into the AbpSettings table.

[ismcagdas]

Yes, in that case the setting will be retrieved from setting definition in code behind, not from database. By the way, I couldn't understand what is your point here.

[worthy7]

So, if the setting is not stored, how does AbpUserRequestCultureProvider know that it should NOT change the users language?

If the user is known but has not selected any language

It is not a reliable way to know if the user has selected a language. If the app default language is en-US then it cannot know if the user has selected no language or selected en-US