Comments (10)
Maybe adding "image/svg+xml" to the default types.
from basicmiddleware.
Putting in 1.1.0 for now. We can move it to 1.2.0 if we can't finish this off in time.
from basicmiddleware.
GZipStream allocations: https://github.com/dotnet/corefx/issues/12549
from basicmiddleware.
@Tratcher Per PM decision, version numbers for new packages will be 1.0.0-preview1 for the initial release. (Not 1.1.0-preview1)
from basicmiddleware.
Review feedback:
- Should the services be registered as singleton or transient? Eilon said Singleton.
- Split ResponseCompressionExtensions by services vs appbuilder.
- Rename EnableHttps to EnableForHttps
- Try binding Options from Config
- Configurable services should resolve their own options rather than being instantiated, configured, and registered as instances.
- See how MVC adds filters, something about adding the type to am list on options and then creating the type from DI.
- Remove the
AddResponseCompression(params string[])
overload, investigate defaults and wildcards instead. Text/*, Application/javascript. #121
from basicmiddleware.
Reading from config works pretty well:
{
"section": {
"EnableForHttps": true,
"MimeTypes": ["text/plain", "text/html"]
}
}
services.AddResponseCompression(options =>
{
Configuration.GetSection("section").Bind(options);
});
from basicmiddleware.
Possible default mime types (things used by the template, static files):
text/css
text/html
application/javascript
WebApi:
application/xml
text/xml
application/json
text/json
application/json-patch+json
Other:
text/plain
from basicmiddleware.
@Yves57 justification? We're not trying to capture every possible type, just the ones to make the 90% scenario work. I based this list on the files included in the full WebApp template, as well as those types from MVC/WebAPI.
from basicmiddleware.
Closing this now that we've worked through the main checklists. Further questions, feedback, etc. should be filed in new issues.
from basicmiddleware.
@Tratcher Because SVG is a standard included in W3C recommandations. So I don't think it's "exotic"...
from basicmiddleware.
Related Issues (20)
- URL rewrite canot get original url HOT 1
- Response Compression not working correctly for React projects HOT 2
- Turn on Compression based on Referrer to avoid BREACH HOT 1
- Add IIS Application Initialization support to AddHttpsRedirection HOT 1
- Compression not working depeding on User-Agent HOT 3
- [Breaking Change] Add duplicate constructor for HSTS middleware HOT 2
- ::ffff:127.0.0.1 not recognized as trusted local proxy HOT 5
- Add support for .NET Framework to BrotliCompressionProvider (when available) HOT 4
- `app.UseHttpsRedirection()` behind IIS HOT 8
- UseForwardedHeaders overrides authority Url of OpenIdConnect HOT 4
- URL rewrite doesn't work for non-regex HOT 10
- IPEndPointParser exception HOT 5
- IPv4 to IPv6 Mapped Addresses not mapped to IPv4 when checking known proxies/networks HOT 5
- OverrideHeaderMiddleware doesn't handle X-Forwarded-For inside a docker container HOT 1
- HostFilteringMiddleware uses C# interopolated strings for tracing HOT 3
- Feature: Break Invoke method into two (PreInvoke and PostInvoke) HOT 2
- ResponseCompression dies and website is offline HOT 5
- Direct middleware for http methods HOT 3
- HttpsRedirectionMiddleware should support conditionally redirecting if X-Forwarded-Proto is available HOT 2
- Enable response compression support for WebAssembly by default HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from basicmiddleware.