UI Issue in Scroll Container about 450-dsa

[AsishRaju]

@ritikrana4 I couldn't get the part where you mention merge footer into the navbar, currently, there is no navbar. 😅,
( and if if you have any plans on keeping a navbar I am a little skeptical about that ).

one more thing which I am not able to figure out is in dark mode the question table color you can have a look at #4 the homepage looks fine but when moved to the topic where question table is seen, it looks awful.

I am open to pr and suggestions on this 👍

[ritikrana4]

1. There is No Navbar but I was thinking to add one and add about page link to it. And a button to toggle theme.
   2.I am using Context to pass theme to the whole app component so will change try to change CSS classes according to that.

• If you can remove that white space above the About footer then we can skip Navbar.
  

[AsishRaju]

@ritikrana4 can you tell me how that white space is being generated is it all the time? coz I don't see any problem with the CSS ( that's causing this problem)

[ritikrana4]

In CSS Container-scroll is using about 60vh. If you make it 100vh then it will work fine but then about the footer will lose its absolute position. I tried to fix it but the code has many library CSS classes, so unable to find.

[AsishRaju]

src/components/TopicCard/topicCard.css

It's because of 65vh, changing that to 100vh would definitely solve the problem in one view but in others, it will breakout and some topics will go below the footer. well even I am not able to figure out how to resolve that, I came up with that number using hit and trial 😅 and also checking responsiveness in each view

@ritikrana4 look at #4 I don't see any issues with that I think it is also using context to pass theme, give it a try or move on with navbar, lets see if it looks better than our janky footer 😏

[ritikrana4]

ok, @AsishRaju let me try it.

[HemantJangid]

Is this issue fixed?

[AsishRaju]

@HemantJangid not yet

[HemantJangid]

Hi, I am not seeing what's the issue here. not seeing this white space. Any particular scenario where this happens? [image: image.png]

…

On Tue, Jun 28, 2022 at 1:02 PM Asish ***@***.***> wrote: @HemantJangid <https://github.com/HemantJangid> not yet — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALLGZOXCHKZ64RZXZOVXTLDVRKS7PANCNFSM4TMMMXLQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Regards, Hemant Jangid https://www.linkedin.com/in/jhemant/

[AsishRaju]

@HemantJangid appreciate you for taking out time and look into this issue, after going back to the history of this issue, I guess there were some CSS issues involved with responsiveness and footer position and came into light when the dark mode was being implemented, but things look good now hence closing this issue, for now, but please feel free to open if anything catches to your eye. Thanks again